Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update offline schema to not fail on unused arguments (such as watch) #68

Closed
tstackhouse opened this issue Feb 5, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tstackhouse
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When attempting to create an e2e project to test an api built with nx-serverless:offline, it fails with a schema validation error because the watch option is passed by the cypress builder, but it is not part of the schema for serverless:offline and additionalProperties is set to false.

Describe the solution you'd like
To the schema for nx-serverlss:offline, either watch is added as e.g. an enum boolean that is always true or additionalProperties is set to true so that unused arguments are simply ignored rather than causing a hard fail.

Describe alternatives you've considered
The only real alternative would be to run 2 separate processes, starting the api manually, then having a cypress instance configured to not run a builder at all.

Check which provider is affected:
[x] AWS
[] Azure
[] Google Cloud Platform

Check which framework is affected:
[] Angular
[] Nodejs
[x] Serverless
[] Lambda
[] Infrastructure as a code

Additional context
I made this exact change in my node_modules and everything ran as expected.

@tstackhouse tstackhouse added the enhancement New feature or request label Feb 5, 2021
@tstackhouse
Copy link
Collaborator Author

Along the same lines, it looks like offline doesn't return a baseUrl requiring one to bet set in cypress.json.

@tstackhouse
Copy link
Collaborator Author

Fixed by #73.

@tstackhouse tstackhouse changed the title [FEAT] Update offline schema to not fail on unised arguments (such as watch) [FEAT] Update offline schema to not fail on unused arguments (such as watch) Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants