Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-serverless): allow & ignore additional options for offline builder #73

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

tstackhouse
Copy link
Collaborator

@tstackhouse tstackhouse commented Feb 17, 2021

Details: Prevents failures if nx-serverless offline is passed unknown options, instead silently ignoring them. Allows the usage of nx-serverless with the built in nx cypress implementation for making e2e tests on the api layer

Breaking Changes: n/a

Fixes/Feature #68

  • yarn affected:test succeeds
  • yarn affected:e2e succeeds
  • yarn format:check succeeds
  • Code coverage does not decrease (if any source code was changed)
  • If applicable, appropriate Wiki docs were updated (if applicable)
  • If applicable, code review comments are written in the source code with / {Name}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants