Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/serverless 2 #80

Merged
merged 11 commits into from
Jun 3, 2021
Merged

Migrate/serverless 2 #80

merged 11 commits into from
Jun 3, 2021

Conversation

wickstargazer
Copy link
Member

Details:

  • Migrated nx workspace to 12
  • Remove support for angular-universal
  • refactored schematics to use the nx-devkit tool
  • refactored all executors to use Executor Context from nx-devkit

Breaking Changes:

  • All executor tests are not working and will need re-write
  • E2E should not be working as well.
  • Offline command is not working, its giving trouble when watching for file (if written with execSync) OR just exiting the command line if using fork --> I NEED HELP!

Fixes/Feature #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • yarn affected:test succeeds
  • yarn affected:e2e succeeds
  • yarn format:check succeeds
  • Code coverage does not decrease (if any source code was changed)
  • If applicable, appropriate Wiki docs were updated (if applicable)
  • If applicable, code review comments are written in the source code with / {Name}

wickstargazer added 10 commits May 15, 2021 12:44
issue #49 remove config from initial serverless.yml
add cache_version to circleci
ignore
yarn.lock
for depsbot
ISSUES CLOSED: #49
issue #49 remove config from initial serverless.yml
add cache_version to
circleci
ignore
yarn.lock
for depsbot
ISSUES CLOSED: #49
…rk with nx latest version

issue #49 remove config from initial serverless.yml
add cache_version
to
circleci
ignore
yarn.lock
for depsbot
ISSUES CLOSED: #49
…w nx workspace

issue #49 remove config from initial serverless.yml
add
cache_version
to
circleci
ignore
yarn.lock
for depsbot
ISSUES CLOSED: #49
…l. issue #72

migrated to nx 12
refactored generators to use nx-devkit
stuck with rxjs version change and compile
error
migrated to nx 12
refactored generators to use nx-devkit
stuck with rxjs version change and
compile
error
… new way. no test yet left with offline command
@wickstargazer wickstargazer self-assigned this May 23, 2021
@wickstargazer wickstargazer added the enhancement New feature or request label May 23, 2021
@wickstargazer
Copy link
Member Author

experiencing this error althought it does not happen when using yank link @flowaccount/nx-serverless locally

 TypeError: Cannot read property 'map' of undefined
      at D:\Projects\opensource\nx-11-test\nx-11-test-serverless\node_modules\copy-webpack-plugin\dist\index.js:51:52
      at AsyncSeriesHook.eval [as callAsync] (eval at create (D:\Projects\opensource\nx-11-test\nx-11-test-serverless\node_modules\tapable\lib\HookCodeFactory.js:33:10), <anonymous>:7:1)
      at AsyncSeriesHook.lazyCompileHook (D:\Projects\opensource\nx-11-test\nx-11-test-serverless\node_modules\tapable\lib\Hook.js:154:20)

…g in generator, fix build,deploy unit-test

fix serve bug and hot reload
add importHelper:false so tslib module error is gone when deploy
fix
unit-tests not done with unit tests yet

ISSUES CLOSED: #72
@wickstargazer
Copy link
Member Author

wickstargazer commented May 24, 2021

i have published 1.0.0-beta.3 the main commands are working now
build, serve, deploy, destroy

known issue: need to add aws-lambda to package.json on init or build will have skipped error

have to test out sls and compile. Finish the unit test fix docs and release the 1.0.0!

@wickstargazer wickstargazer merged commit f22b58d into master Jun 3, 2021
wickstargazer added a commit that referenced this pull request Jun 3, 2021
wickstargazer pushed a commit that referenced this pull request Jun 3, 2021


fix serve bug and hot reload
add importHelper:false so tslib module error is gone when
deploy
fix
unit-tests not done with unit tests yet
ISSUES CLOSED: #72
@wickstargazer wickstargazer mentioned this pull request Jun 3, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant