-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-serverless): Create deploy package.json with proper external modules/dependencies #89
Conversation
way to go, just a simple config fix. Apologies for being off radar :) |
@wickstargazer When will this be published to new version of npm package? |
sorry guys, i have been lost in the aws world of pain. I will take a look at this to publish it asap |
@wickstargazer was the fix here not sufficient hence the revert? |
@wickstargazer I'm also curious, were the config changes not sufficient? Or are you planning bigger changes that take care of this issue? |
yes it is @brian-weasner i have just been in a different context. and couldn't switch. I would want some feedback on how to invite more contributors and publishers to the project. Anyone interested? I would start a slack channel for it :) |
published 1.0.0-beta.5 |
@wickstargazer I believe I would be interested in joining a slack channel to discuss contributions/how to invite more contributors. |
* fix(nx-serverless): Create deploy package.json with proper external modules/dependencies (#89) * Create deploy package.json with proper external modules/dependencies * Modify Stats Config to Always have chunks and modules in chunks to get external modules * add missing compat file for sls executor Co-authored-by: Brain Weasner <84519320+brian-weasner@users.noreply.github.com> Co-authored-by: Wick <voravit@flowaccount.com>
* fix(nx-serverless): Create deploy package.json with proper external modules/dependencies (#89) * Create deploy package.json with proper external modules/dependencies * Modify Stats Config to Always have chunks and modules in chunks to get external modules * fix(nx-serverless): fixed overlapping service and function paths cased by some plugins I have been having compatabilty issues with serverless-import-config-plugin Co-authored-by: Brain Weasner <84519320+brian-weasner@users.noreply.github.com> Co-authored-by: Wick <voravit@flowaccount.com>
Details: Update webpack stats
getExternalModules
function to get external modules with webpackstats objectBreaking Changes: Should not cause any as I am adding values to the webpack stats and not removing them
Fixes #86