Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-serverless): Create deploy package.json with proper external modules/dependencies #89

Merged
merged 2 commits into from
Jul 25, 2021

Conversation

brian-weasner
Copy link
Contributor

@brian-weasner brian-weasner commented Jul 16, 2021

Details: Update webpack stats getExternalModules function to get external modules with webpackstats object

Breaking Changes: Should not cause any as I am adding values to the webpack stats and not removing them

Fixes #86

  • yarn affected:test succeeds
  • yarn affected:e2e succeeds
  • yarn format:check succeeds
  • Code coverage does not decrease (if any source code was changed)
  • If applicable, appropriate Wiki docs were updated (if applicable)
  • If applicable, code review comments are written in the source code with / {Name}

@wickstargazer
Copy link
Member

way to go, just a simple config fix. Apologies for being off radar :)

@wickstargazer wickstargazer merged commit f7ac488 into flowaccount:master Jul 25, 2021
@milocosmopolitan
Copy link
Contributor

@wickstargazer When will this be published to new version of npm package?

@wickstargazer
Copy link
Member

sorry guys, i have been lost in the aws world of pain. I will take a look at this to publish it asap

wickstargazer added a commit that referenced this pull request Aug 27, 2021
…ternal modules/dependencies (#89)"

This reverts commit f7ac488.
@tataihono
Copy link

@wickstargazer was the fix here not sufficient hence the revert?

@brian-weasner
Copy link
Contributor Author

@wickstargazer I'm also curious, were the config changes not sufficient? Or are you planning bigger changes that take care of this issue?

@wickstargazer
Copy link
Member

yes it is @brian-weasner i have just been in a different context. and couldn't switch. I would want some feedback on how to invite more contributors and publishers to the project. Anyone interested? I would start a slack channel for it :)

@wickstargazer
Copy link
Member

wickstargazer commented Aug 31, 2021

published 1.0.0-beta.5

@brian-weasner
Copy link
Contributor Author

@wickstargazer I believe I would be interested in joining a slack channel to discuss contributions/how to invite more contributors.
Ps. Ran into some issues with the deploy not working with the new release because the packager was defaulted to yarn and I had to look through the source to figure out where the "packager": "npm" needed to be set.

wickstargazer added a commit that referenced this pull request Nov 3, 2021
* fix(nx-serverless): Create deploy package.json with proper external modules/dependencies (#89)

* Create deploy package.json with proper external modules/dependencies

* Modify Stats Config to Always have chunks and modules in chunks to get external modules

* add missing compat file for sls executor

Co-authored-by: Brain Weasner <84519320+brian-weasner@users.noreply.github.com>
Co-authored-by: Wick <voravit@flowaccount.com>
wickstargazer added a commit that referenced this pull request Nov 3, 2021
* fix(nx-serverless): Create deploy package.json with proper external modules/dependencies (#89)

* Create deploy package.json with proper external modules/dependencies

* Modify Stats Config to Always have chunks and modules in chunks to get external modules

* fix(nx-serverless): fixed overlapping service and function paths cased by some plugins

I have been having compatabilty issues with serverless-import-config-plugin

Co-authored-by: Brain Weasner <84519320+brian-weasner@users.noreply.github.com>
Co-authored-by: Wick <voravit@flowaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] External dependencies are unavailable after deploying
4 participants