-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bold+Italic variant? #5
Comments
I think the caveat from the original font probably applies: Lines 128 to 134 in b50a975
Doing it the "right way" would involve making an entire new glyph set by hand which is a non-starter (at least for me). If some enterprising brave soul wanted to do it, I wouldn't stop them, but it's a lot. Having said that, there IS an old tool that's designed specifically for this purpose: http://hp.vector.co.jp/authors/VA013651/freeSoftware/mkbold-mkitalic.html Though I haven't tried it. The results might be awful, or they might mostly work, however you'd probably want to make sure you only applied it to the glyphs that are actually italic and not already bold (i.e. not the Hebrew ones), and I'm guessing there would be some manual tweaking necessary after that. I might take a crack at it later, but if you want to get this done sooner, that's where I'd start. If it works out, please submit a PR to add it to the build system. Based on nothing other than my gut feeling, I would say to start with mkbold on the italic variant, rather than mkitalic on the bold variant, since italic has its own sylistic elements compared to the normal font, and I don't know if mkitalic is smart enough to do that. |
Hah! I may have spoken too soon. Preliminary results from mkbold on the italic version of 18px doesn't actually look TOO awful. It might not be too much work to integrate this into the preliminary build Dockerfile in
Then I added the bdf to the toplevel Makefile And then I had to manually edit the header of the BDF to refer to it as a
So that would need to be scripted somehow, but it's do-able! |
The right way is probably to do a one-time conversion using |
Thanks for all the details and references! I gave the conversion a shot with some updated parameters
It looks like it helped preserve some of the shapes a bit better ( Comparison |
This is now integrated into the new build process, and the files are available in I'm using the flags you were using, which does indeed look better, however I'm still not satisfied with the cropping. There are also some "missing" internal pixel artifacts, but it's unclear if there is any kind of simple approach that might fix that. Worst comes to worst, we could probably create a character-by character fix list for the ASCII characters and get 90% of the way there with that. I've opened #6 to track this. But I digress. Now we have BoldItalic fonts! Yay! Thanks for your submission! |
First, wanted to say thanks for making such a great font! I've been using it for the past six months and love it. Having standard, bold, and italic variants really makes it stand out (and much more useful as a result) among the other bitmap fonts I've come across.
Would you consider making a bold+italic font variant?
The three variants provided currently cover 95% of my use cases, but with kitty's font config I do run into occasional cases where the
bold_italic_font
is expected and I have to use a fallback. Having a bold+italic for Greybeard would really complete this font and make it usable across all applications I need.Thanks! Feel free to close if it's not something you're interested in (or if it's not possible to do with the design of the font at its current sizes).
The text was updated successfully, but these errors were encountered: