Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor configuration from process environment #80

Merged
merged 16 commits into from
May 9, 2023

Conversation

andreikop
Copy link
Contributor

Description

When Flowforge works in K8s cluster, it might be necessary to set some K8S cluster specific settings of editor instances created by FF.
Those settings are likely to be generated by deployment scripts and set by DevOpses, not by team administrators on WebUI, therefore we think that is is most convenient to store in in flowforge process environment but not in the database.

This PR adds next settings:

  • INGRESS_CLASS_NAME - Ingress class name for editor instances
  • INGRESS_ANNOTATIONS - Ingress annotations for editor instances as JSON-encoded object
  • DEPLOYMENT_TOLERATIONS - Editor Deployment tolerations as JSON-encoded object

The changes are backward compatible.
PR for FF Helm which allows to set those settings TBD.

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@elenaviter elenaviter mentioned this pull request Apr 4, 2023
11 tasks
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
@hardillb
Copy link
Contributor

hardillb commented May 4, 2023

@andreikop Can you look at my comments please, I'd like to get this merged today ahead of the release next week.

Thanks

kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
kubernetes.js Outdated Show resolved Hide resolved
@hardillb hardillb merged commit 08869a0 into FlowFuse:main May 9, 2023
@hardillb hardillb mentioned this pull request May 11, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants