-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor configuration from process environment #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
hardillb
reviewed
Apr 12, 2023
hardillb
reviewed
Apr 12, 2023
hardillb
requested changes
Apr 12, 2023
@andreikop Can you look at my comments please, I'd like to get this merged today ahead of the release next week. Thanks |
hardillb
requested changes
May 9, 2023
hardillb
requested changes
May 9, 2023
hardillb
reviewed
May 9, 2023
hardillb
approved these changes
May 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Flowforge works in K8s cluster, it might be necessary to set some K8S cluster specific settings of editor instances created by FF.
Those settings are likely to be generated by deployment scripts and set by DevOpses, not by team administrators on WebUI, therefore we think that is is most convenient to store in in flowforge process environment but not in the database.
This PR adds next settings:
INGRESS_CLASS_NAME
-Ingress
class name for editor instancesINGRESS_ANNOTATIONS
-Ingress
annotations for editor instances as JSON-encoded objectDEPLOYMENT_TOLERATIONS
- EditorDeployment
tolerations as JSON-encoded objectThe changes are backward compatible.
PR for FF Helm which allows to set those settings TBD.
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label