Use shared subscriptions where appropriate for HA support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Steve-Mcl I've updated the nodes to only use shared subs if the settings file sets a flag called This will mean devices continue to use regular topics as intended. |
knolleary
commented
Jun 7, 2023
Steve-Mcl
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the project nodes to use a shared subscription where appropriate to enable HA support.
All subscriptions (except link call response topic) now uses a shared subscription. The group id of the share is set to the project id.
The link call response topic now includes a randomly generated (per-node) string appended to
res-. For this to work, that string is also passed in themessageEventproperty of the published message. That allows the returning node to reconstruct the appropriate topic to send the reply to.This all requires a FlowForge platform instance that includes FlowFuse/flowfuse#2225
This feature should be published with a major version bump to ensure existing installs of FF do not pick this change up.