Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Stack and Templates #989

Closed
sammachin opened this issue Sep 15, 2022 · 4 comments · Fixed by #1013
Closed

Default Stack and Templates #989

sammachin opened this issue Sep 15, 2022 · 4 comments · Fixed by #1013
Assignees
@knolleary
Labels
area:frontend For any issues that require work in the frontend/UI task A piece of work that isn't necessarily tied to a specific Epic or Story.
Milestone
0.10

Comments

@sammachin
Copy link
Contributor

Description

Make the 1st Stack and Template on the new project screen selected be default so a user doesn't have to make a choice.

This is in keeping with our priniciple of Sensible Defaults

Epic/Story

No response
@sammachin sammachin added task A piece of work that isn't necessarily tied to a specific Epic or Story. area:frontend For any issues that require work in the frontend/UI labels Sep 15, 2022
@sammachin sammachin added this to the 1.0 milestone Sep 15, 2022
@sammachin sammachin mentioned this issue Sep 20, 2022
Closed
@sammachin
Copy link
Contributor Author

Where there is only a single option available to a user they should not even be shown the choice it should just be set automatically

@knolleary knolleary self-assigned this Sep 23, 2022
@knolleary
Copy link
Member

We already have the concept of a ProjectType's default stack - and it gets preselected on the Create Project page when that ProjectType is selected.

However there is a bug. If a stack has been replaced by another, the ProjectType's default stack entry isn't being updated - so still points to the old stack. As that stack doesn't show up on the create project page, nothing gets selected.

I've fixed up the page so that it ensures something is selected. I'll also sort out the bug described above.

As for hiding the selection entirely - I think there is a case to be made to hide the Template option if there's only one - as we don't yet have much functionality for end users around multiple templates.

But I do think stacks are different because they determine details of the project that are useful to know up front - NR version for example (and will be better once we have #915).

So I propose to hide the Template row if there's only one, but leave the Stack there.

@sammachin
Copy link
Contributor Author

So I propose to hide the Template row if there's only one, but leave the Stack there.

agreed

@knolleary knolleary mentioned this issue Sep 23, 2022
Merged
@sammachin
Copy link
Contributor Author

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knolleary knolleary

Labels
area:frontend For any issues that require work in the frontend/UI task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
🛠 Development
Archived in project
Milestone
0.10
Development

Successfully merging a pull request may close this issue.

Ensures stack/template are preselected on Create Project page FlowFuse/flowfuse
2 participants
@knolleary @sammachin