Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Instances: Audit Log Screen #1782

Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 8, 2023

Merge target is the feature branch for application instances as part of #1689: feat-1689-application-instances

Description

  • Extracts common functionality of the Audit Log into a separate component
  • Uses that component on all existing Audit Log pages
  • Adds a dropdown to select instance to the application view

Application View

Screenshot 2023-03-08 at 15 59 19

Screenshot 2023-03-08 at 16 02 46

Instance View

Screenshot 2023-03-08 at 16 02 56

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary March 8, 2023 15:13
@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 8, 2023

FYI the new dropdown is currently affected by this bug: FlowFuse/forge-ui-components#126, fixed in FlowFuse/forge-ui-components#127

@knolleary
Copy link
Member

I appreciate this is an existing UX thing, so we can pull this into a separate issue, but I think the 'Not specified' labels would be better replaced with 'All instances'/'All events'/'All Users' etc. It's a more positive reflection of what it's showing.

image

@knolleary knolleary merged commit 1291be0 into feat-1689-application-instances Mar 9, 2023
@knolleary knolleary deleted the feat-1719-application-logs branch March 9, 2023 10:56
@Pezmc Pezmc mentioned this pull request Mar 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants