Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Instances #1792

Merged
merged 45 commits into from
Mar 9, 2023
Merged

Application Instances #1792

merged 45 commits into from
Mar 9, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 9, 2023

Description

Implements a new abstraction of Node-RED instances that replaces FlowForge projects.

There are now two layers:

  • Application - a collection of Node-RED instances owned by a particular team
  • Instance - a FlowForge hosted instance of Node-RED

This supplements the existing devices, which are remote instances of Node-RED managed by FlowForge.

This feature branch been reviewed as separate PR's and is being merged to main to deploy to staging, further improvements will be handled as follow ups.

Related Issue(s)

#1718 Story #1689 Epic

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

Pezmc and others added 30 commits March 2, 2023 14:21
@Pezmc
Relatively naive copy of all of projects functionality
02ba15b
@Pezmc
Create instance API and use it for /instances
867de52
@Pezmc
Rename events to be instance related
3ddad77
@Pezmc
Move nested routes into a sub routes file
8bbd9f9
@Pezmc
Hero is optional (can set slot), options should default to empty array
22d4547
@Pezmc
Navigate to instances from the project instances table
f2b7679
@Pezmc
Move the top menu to exist on all pages
8ab9c24 
Effectively undoing the work in #1237 for instances
@Pezmc
/s/project/instance for the top level files
981ce84
@Pezmc
Basic test coverage that instances page loads
827bd08
@knolleary
Merge pull request #1765 from flowforge/feat-1718-instances
6e57538 
Duplicate all project functionality under instances
@Pezmc
Set all instances pages not to auto-inherit router-view props
edba602 
https://vuejs.org/guide/components/attrs.html#disabling-attribute-inheritance
@Pezmc
Remove Overview page
614ace8
@Pezmc
Rename Project > Instances to Project > Overview
3caeb41
@Pezmc
Remove Project > Snapshots in favour of Instance > Snapshots
525cd58
@Pezmc
Gut the project settings
2b15d56
@Pezmc
Add a back button to the instance nav
fed06f3
@Pezmc
Migrate relevant project test coverage to instances
8de147b
@Pezmc
Update the URL
68899dd
@Pezmc
s/Project/Instance for all user facing text
d66117e
@knolleary
Merge pull request #1769 from flowforge/feat-1719-project-navigation
6ddd2da 
Application Instances: Simplify Project Navigation
@Pezmc
First pass of Project -> Application or Application Instance
3a89da9
@Pezmc
Test failure fixes
16e5a27
@Pezmc
First pass of Project -> Application or Application Instance
1ac874e
@Pezmc
Put ChipIcon back
53198b6
@Pezmc
Delete unused project components
09dcfe5
@Pezmc
Link to application and instance from device tables
7f0393b
@Pezmc
Add note
8ae8229
@Pezmc
Assigning devices copy changes
c30cb01
@Pezmc
Possible to create instance from project overview
1ade37e
@Pezmc
Merge pull request #1775 from flowforge/feat-1718-instance-ui-tweaks
c77f532 
Reference Instance or Application rather than Project in the UI
Pezmc and others added 15 commits March 8, 2023 12:19
@Pezmc
Merge pull request #1777 from flowforge/feat-1718-instance-ui-tweaks-2
25cec75 
Further renaming of project to application
@Pezmc
Merge branch 'main' into feat-1689-application-instances
10316f0
@Pezmc
Extract shared functionality into separate audit log file
18824d9
@Pezmc
Use shared audit log functionality for projects
b37ccdc
@Pezmc
Use shared audit log for admin/team
d38352c
@Pezmc
Rename SharedAuditLog to AuditLogBrowser
a015d23
@Pezmc
Add instance filter to application log page
9297be2
@Pezmc
Remove unused import
a756dc5
@Pezmc
Extract shared node-red logs behaviour to a component
8aa3aaf
@Pezmc
Add an instance filter to application node-red log page
2139aa1
@Pezmc
Move shared component to components dir
7b65b01
@Pezmc
Add a quick link to jump to instance
ff8404b
@knolleary
Merge pull request #1783 from flowforge/feat-1719-node-red-logs
0e0801f 
Application Instances: Node-RED Logs Page
@knolleary
Merge pull request #1782 from flowforge/feat-1719-application-logs
1291be0 
Application Instances: Audit Log Screen
@Pezmc
Update forge-ui-components
46eb98d
@Pezmc Pezmc requested a review from knolleary March 9, 2023 17:06
@Pezmc Pezmc merged commit 530f5e2 into main Mar 9, 2023
@Pezmc Pezmc deleted the feat-1689-application-instances branch March 9, 2023 17:36
This was referenced Mar 9, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pezmc @knolleary