Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout for widgets in group seems wrong. Missing CSS declaration grid-row-end: span [rows] #570

Closed
hotNipi opened this issue Feb 12, 2024 · 4 comments · Fixed by #580
Closed
Assignees
Labels
bug Something isn't working Dashboard 1.0 This is a feature of Dashboard 1.0 that has not yet been migrated to Dashboard 2.0 priority:high High Priority size:XS - 1 Sizing estimation point

Comments

@hotNipi
Copy link
Contributor

hotNipi commented Feb 12, 2024

Description

Preconditions: Group size is 6x1
Expected layout :

image

Where 2x2 button is second in order.

image

The actual outcome is:

image

The grid-row-end declaration is applied to the component but not for the containing div.
This is same for all layouts, I took the reference image from layouts/Grid.vue

image

Both elements - the component and the container should have grid-row-end: span [rows] declarations. Otherwise I can't imagine it will somehow possible to arrange widgets in group.

Best,
Endel

Epic/Story

No response

Have you provided an initial effort estimate for this issue?

I can not provide an initial effort estimate

@hotNipi hotNipi added the task A piece of work that isn't necessarily tied to a specific Epic or Story. label Feb 12, 2024
@hotNipi
Copy link
Contributor Author

hotNipi commented Feb 15, 2024

Hi @joepavitt

I do shake this issue thread a bit just to get a little attention.
That is because I'm pretty sure it is a bug which in my world should get priority emergency. See that there is bunch of people trying to migrate from DB1 already and this is something which stands as obstacle.
I have provided workaround for couple of my followers but I'd like to not share it widely cos I'm not sure about the future of this.

So if I'm right and it is a bug - it's a 10 minute fix as described, if not - I'd like to hear how it should be possible to manage the widgets layout in group properly.

Thanks,
Endel

@joepavitt joepavitt added size:XS - 1 Sizing estimation point priority:high High Priority Dashboard 1.0 This is a feature of Dashboard 1.0 that has not yet been migrated to Dashboard 2.0 labels Feb 15, 2024
@joepavitt
Copy link
Collaborator

Thanks Endel, will sort today. I'm only on Dashboard two days a week (today and tomorrow) so hadn't had a chance to look at this yet

@joepavitt joepavitt added bug Something isn't working and removed task A piece of work that isn't necessarily tied to a specific Epic or Story. labels Feb 15, 2024
@joepavitt joepavitt self-assigned this Feb 15, 2024
@joepavitt
Copy link
Collaborator

Fix incoming - thanks for the assist @hotNipi

Screenshot 2024-02-15 at 08 42 03

@hotNipi
Copy link
Contributor Author

hotNipi commented Feb 15, 2024

Thank you :)
This maybe now can help also sort out the ordering issue mentioned here https://discourse.nodered.org/t/node-ordering-in-groups/85448
I have some doubths those may be slightly related ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dashboard 1.0 This is a feature of Dashboard 1.0 that has not yet been migrated to Dashboard 2.0 priority:high High Priority size:XS - 1 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants