Merge pull request #23 from flownative/task/getobjects-speedup

Avoid array_merge in loop in getObjects()
flownative · Feb 3, 2022 · 198277b · 198277b
2 parents fe93774 + fd1d0e5
commit 198277b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/Classes/GcsStorage.php b/Classes/GcsStorage.php
@@ -376,10 +376,10 @@ public function getObjects()
     {
         $objects = [];
         foreach ($this->resourceManager->getCollectionsByStorage($this) as $collection) {
-            /** @noinspection SlowArrayOperationsInLoopInspection */
-            $objects = array_merge($objects, $this->getObjectsByCollection($collection));
+            $objects[] = $this->getObjectsByCollection($collection);
         }
-        return $objects;
+
+        return array_merge([], ...$objects); // the empty array covers cases when no loops were made
     }
 
     /**