Authorization ID must not be deterministic for authorization code flow #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that client code can distinguish between multiple authorization ids which may be provided via HTTP query parameters in an "OAuth2 finish authorization" request. This may happen, for example, when a user returns from a service like Github, and granted permissions to your application, and at the same time authentication is triggered via OIDC. In that case, you might end up with a "finish authorization" request in Flow which has two authorization ids in its URL, one for Github OAuth and one for OIDC OAuth.
robertlemke
changed the title
This change modifies Doctrine's column schema for the serialized access token so it's stored as a string, not as an "array". This doesn't change any actual data in the database, but changes the set- and getSerializedAccesstoken() methods which now expect a string instead of an array. This change also improves test coverage of the Authorization class.
Remove the client secret from the Authorization table – for now at least. We don't need to store the client secret, because if OAuth is used with client credentials flow, the client secret is likely available somewhere lese (for example via a setting or an application specific storage) and when authorization code flow is used, the secret is only needed when authorization is started and does not have to be stored. We may need the client secret for refreshing a token, but this is not correctly implemented at this time, so we may need to solved this at a later point in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13