Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

This isn't functional #1

Closed
niftylettuce opened this issue Feb 9, 2012 · 6 comments
Closed

This isn't functional #1

niftylettuce opened this issue Feb 9, 2012 · 6 comments

Comments

@niftylettuce
Copy link

You are using mixins that already exist in nib

Improve it! 👍

@flowonyx
Copy link
Owner

flowonyx commented Feb 9, 2012

By "This isn't functional" I assume you mean that you couldn't clone it using the url in the instructions, which I have updated. If you mean something else, please be more specific, because it works fine on my computers.

I will not be using nib because it adds an unnecessary layer of complexity to include it (unless I'm just stupid and don't see the simple way, which is very possible). [EDIT: Removed statement regarding the "dumb" vendor mixins, which are actually very "smart".] Also the clearfix mixin has "zoom: 1" instead of "*zoom: 1" and while I haven't looked at the difference myself, I trust the experts.

What I did do, was fix it so that if you want to include nib, it will not blow up as it did previously due to the linear-gradient mixin. If you see a way to fix these problems while including nib, by all means send me a pull request.

@flowonyx flowonyx closed this as completed Feb 9, 2012
@tj
Copy link

tj commented Feb 10, 2012

nib doesn't blindly add prefixes to everything.. not sure where you get that. If opera doesn't support box-shadow we simply add ignore: o to nib.

@DAddYE
Copy link

DAddYE commented Feb 10, 2012

@visionmedia why dont you provide an official port of bootstrap (like others do with sass) ? This repo seems a good starting point. No?

@tj
Copy link

tj commented Feb 10, 2012

I dont use it, so I dont really have the time to invest in it. Once Stylus supports the client-side better like LESS there is almost no reason that bootstrap itself shouldn't be Stylus

@flowonyx
Copy link
Owner

@visionmedia Then I certainly apologize for getting that wrong. I just realized that the npm installed version of nib is different from what is on github (the npm version doesn't have -o and -ms prefixes in the config's vendor-prefixes). But I just didn't notice the option for ignoring specific prefixes.

When I get time, I may try it again.

@tj
Copy link

tj commented Feb 10, 2012

in that case we would just change:

box-shadow()
  vendor('box-shadow', arguments)

to

box-shadow()
  vendor('box-shadow', arguments, ignore: o)

easy :) some of them I'm just not aware of because I don't bother with opera, I dont think I even have it installed anymore

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants