Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

dvr: consistent timestamp across engines #1137

Closed
phloxic opened this issue Feb 3, 2017 · 3 comments
Closed

dvr: consistent timestamp across engines #1137

phloxic opened this issue Feb 3, 2017 · 3 comments
Assignees
Milestone

Comments

@phloxic
Copy link
Contributor

phloxic commented Feb 3, 2017

For DVR the timestamp is currently not shown. But it is especially useful for DVR.
When one forces it be shown via CSS, it is wrong.
In my opinion it should display the position within the DVR window.
Instead it shows the position within the total duration.

Sample implementation for hlsjs: https://flowplayer.blacktrash.org/fp7/dvr.html
Compare at same address with native playback.
Compare at https://flowplayer.blacktrash.org/fp7/dvr.html?hlsjs=false with flashls.

This only needs a tiny tweak in the percentage calculation for dvr, for native playback this doesn't make any difference as seekOffset is always 0.

@popler - I think it's clearer to show the actual position instead of the distance to the live edge.

@phloxic
Copy link
Contributor Author

phloxic commented Feb 3, 2017

I have moved the timestamp code as little 'plugin' into the HEAD of the demo at https://flowplayer.blacktrash.org/fp7/dvr.html (or https://flowplayer.blacktrash.org/fp7/dvr.html#hlsjs=false); it works imho consistently for all 3 engines (dashjs plugin is a different beast).

@phloxic phloxic added this to the 7.0.2 milestone Feb 4, 2017
phloxic added a commit that referenced this issue Feb 4, 2017
The timestamp is especially informative for DVR as it can show the
current or desired position inside the DVR window. So show it.

The CSS hiding of the timestamp for live (not dvr) can be omitted. It
was redundant anyway because is-live hides the timeline, and therefore
one cannot mousemove over it.
@popler
Copy link

popler commented Feb 5, 2017

@blacktrash Based on your code, I made some modification. You can check at http://www.popler.tv/embed/player7.php?user=poplerhd - player shows minus time form LIVE. I also add some color differences between LIVE and DVR (scrubber, title, LIVE) to better show the difference.

@phloxic
Copy link
Contributor Author

phloxic commented Feb 6, 2017

@popler - as per #1133 my stance is:

  • do not special case the timestamp for DVR with a minus sign, which I find confusing at that place as well
  • imho the minus sign belongs to remaining time, both for VOD and DVR
  • the Live switch is currently a hybrid: it usurps fp-remaining with a boolean switch indicator and functionality, therefore it should be separate

@nnarhinen has to decide.

@nnarhinen nnarhinen modified the milestones: 7.1, 7.0.2 Feb 6, 2017
nnarhinen added a commit that referenced this issue Aug 10, 2017
@nnarhinen nnarhinen modified the milestones: 7.1, 7.2 Aug 17, 2017
nnarhinen pushed a commit that referenced this issue Aug 19, 2017
The timestamp is especially informative for DVR as it can show the
current or desired position inside the DVR window. So show it.

The CSS hiding of the timestamp for live (not dvr) can be omitted. It
was redundant anyway because is-live hides the timeline, and therefore
one cannot mousemove over it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants