Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Duplicate errors with MSE plugins #1142

Closed
phloxic opened this issue Feb 6, 2017 · 1 comment
Closed

Duplicate errors with MSE plugins #1142

phloxic opened this issue Feb 6, 2017 · 1 comment
Assignees
@nnarhinen

Comments

@phloxic
Copy link
Contributor

phloxic commented Feb 6, 2017

With Flowplayer 7 errors triggered by MSE plugins, trigger duplicate messages.
Compare fp7:
https://flowplayer.blacktrash.org/fp7/hlsjs-dummy.html
with fp6:
https://flowplayer.blacktrash.org/fp6/hlsjs-dummy.html

Why is the error catching with fp7 less snappy?

They are also somewhat harder to work around, and recovery looks less clean:
http://demos.flowplayer.org/api/live-check.html sometimes shows the non-custom message element during recovery
http://demos.flowplayer.org/v6/api/live-check.html feels cleaner.

From the UI perspective: why are controls shown? They are unusable in error state. My first reaction is still to click on the play button.

See also: flowplayer/flowplayer-hlsjs#61
phloxic added a commit to flowplayer/flowplayer-hlsjs that referenced this issue Feb 8, 2017
@phloxic
Delay player error after hls.js fatal error w/o recovery
3db4b7d 
- Chrome: error message is not wiped by hls destruction
- Firefox: error message is not duplicated

refs: #61 and flowplayer/flowplayer#1142
@phloxic
Copy link
Contributor Author

phloxic commented Feb 8, 2017

I believe I solved this in the hlsjs plugin. Looks like Flowplayer 7 is more fussy with timings.

@phloxic phloxic closed this as completed Feb 8, 2017
@foliovision foliovision mentioned this issue Jun 28, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nnarhinen nnarhinen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phloxic @nnarhinen