Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

responsive iframe embed code #804

Closed
phloxic opened this issue May 26, 2015 · 0 comments
Closed

responsive iframe embed code #804

phloxic opened this issue May 26, 2015 · 0 comments
Assignees
@phloxic
Labels
new feature
Milestone
7.0

Comments

@phloxic
Copy link
Contributor

phloxic commented May 26, 2015

As the standard embed code is now responsive, try the same with the iframe embed code:

Offer the iframe embed code with wrapper around the iframe which replicates the container/ratio stanza and make the iframe fill it: http://flowplayer.blacktrash.org/fp6/iframe-responsive.html

Plus add padding-bottom to the wrapper: 3px for slim timeline or controlbar height for fixed-controls.

Side effect: no deprecated html5 code, like frameBorder="0".
@nnarhinen nnarhinen added this to the 6.1 milestone May 26, 2015
@phloxic phloxic self-assigned this Sep 30, 2016
phloxic added a commit to phloxic/flowplayer that referenced this issue Sep 30, 2016
@phloxic
Make iframe embed code responsive by default (flowplayer#804)
7036f92 
Arguably it would make sense to require both width and height configured
for a static layout. Especially height only will almost certainly lead
to strange results. Assume users know what they are doing when they
configure a dimension.
phloxic added a commit to phloxic/flowplayer that referenced this issue Sep 30, 2016
@phloxic
Make iframe embed code responsive by default (flowplayer#804)
1f3b758 
Arguably it would make sense to require both width and height configured
for a static layout. Especially height only will almost certainly lead
to strange results. Assume users know what they are doing when they
configure a dimension.
phloxic added a commit to phloxic/flowplayer that referenced this issue Sep 30, 2016
@phloxic
Make iframe embed code responsive if width and height not given (flow…
49b126b 
…player#804)

Arguably it would make sense to require both width and height configured
for a static layout. Especially height only will almost certainly lead
to strange results. Assume users know what they are doing when they
configure a dimension.
phloxic added a commit to phloxic/flowplayer that referenced this issue Sep 30, 2016
@phloxic
iframe embed: handle adaptiveRatio and ratio: false (flowplayer#804)
8b4e8c4
nnarhinen added a commit that referenced this issue Oct 8, 2016
@nnarhinen
Merge pull request #1057 from blacktrash/issue/804
cf47294 
Make iframe embed code responsive if width and height not given (#804)
nnarhinen pushed a commit that referenced this issue Jan 11, 2017
@phloxic @nnarhinen
Make iframe embed code responsive if width and height not given (#804)
a03ab79 
Arguably it would make sense to require both width and height configured
for a static layout. Especially height only will almost certainly lead
to strange results. Assume users know what they are doing when they
configure a dimension.
nnarhinen pushed a commit that referenced this issue Jan 11, 2017
@phloxic @nnarhinen
iframe embed: handle adaptiveRatio and ratio: false (#804)
ffb7117
nnarhinen pushed a commit that referenced this issue Jan 11, 2017
@phloxic @nnarhinen
Make iframe embed code responsive if width and height not given (#804)
a597fef 
Arguably it would make sense to require both width and height configured
for a static layout. Especially height only will almost certainly lead
to strange results. Assume users know what they are doing when they
configure a dimension.
nnarhinen pushed a commit that referenced this issue Jan 11, 2017
@phloxic @nnarhinen
iframe embed: handle adaptiveRatio and ratio: false (#804)
7fd0859
@foliovision foliovision mentioned this issue Jun 27, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@phloxic phloxic

Labels
new feature
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
2 participants
@phloxic @nnarhinen