Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

clip options in playlists are sticky, triggering trouble with picking order #823

Closed
phloxic opened this issue Jun 1, 2015 · 7 comments
Closed
Assignees
Milestone

Comments

@phloxic
Copy link
Contributor

phloxic commented Jun 1, 2015

The following config errs with "Flash: Video file not found" when switching to the 2nd clip:

// setting rtmp on player level also triggers the issue
// rtmp: "my.rtmp.com",
playlist: [{
  rtmp: "my.rtmp.com",
  sources: [
     { type: "video/flash", src: "mp4:video1" },
     { type: "video/mp4", src: "//example.com/video1.mp4" }    
  ]
}, {
  // rtmp: 0, // does not help
  sources: [
    // { type: "video/mp4", src: "//example.com/video-f2.mp4", engine: "flash" }, // does not help
    { type: "video/flash", src: "//example.com/video-f2.mp4" },
    { type: "video/mp4", src: "//example.com/video.mp4" }
  ]
}]

That is: Currently RTMP in a playlist works only if all clips are also available via RTMP.

It can make sense that clip options are sticky, i.e. they do not fall back to to values given on player level if they fall back to their flowplayer.default consistently - but this is not the case with rtmp for instance.

RE doc: If the above description (minus the bug) about stickyness is correct, it must be documented clearly.

See: https://flowplayer.org/forum/#!/setup:flash-video-not-found-in-a

@nnarhinen
Copy link
Member

This should be fixed with assets from http://demos.834f.flowplayer.me/

Even though I did test #834 locally to some extent, it would be awesome if you could test various configurations to see if it did break something regarding playlist clip changes.

@phloxic
Copy link
Contributor Author

phloxic commented Jun 5, 2015

hm, the scenario in #823 (comment) still gives "Flash not found": http://flowplayer.blacktrash.org/fp6/rtmp-vflash.html

@phloxic
Copy link
Contributor Author

phloxic commented Jun 5, 2015

title property is not sticky anymore.

@nnarhinen
Copy link
Member

@blacktrash because you used the assets from #835 and not #834

@phloxic
Copy link
Contributor Author

phloxic commented Jun 8, 2015

Ah, right. 👍
@nnarhinen - doc-wise: can you confirm somthing like:
"rtmp must be set on clip level for all clips if the option does not apply to one clip in a playlist."
?
i.e.

  1. you cannot expect a global rtmp setting to be unset for a "video/flash" clip which is served over http (this scenario)
  2. you cannot expect rtmp to default to the global rtmp value if rtmp differs for one clip in a playlist (also fine, just might have to be documented more clearly)

That is: rtmp should only be set globally in conjunction with a playlist if its value applies to all clips in a playlist, there is no guessing of default values.

EDIT: where "globally" above means: global configuration and configuration at player level.

@nnarhinen
Copy link
Member

the code goes something like

var rtmp = clip.rtmp || player.conf.rtmp;

so now saying

{
  rtmp: '<rtmpurl>',
  clip: {
    rtmp: false
  }
}

would make it use <rtmpurl>.

I could make special logic with rtmp: false to completely disable rtmp for current clip but I don't know if that is easier at all to document.

So the easiest to document I guess is to advice setting rtmp on clip level for playlists if any of the rtmp urls differ.

@phloxic
Copy link
Contributor Author

phloxic commented Jun 8, 2015

Thanks for clarifying. Fine with documenting it the way it is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants