Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

flashdisabled message does not make sense when Flash is in fact enabled #904

Closed
phloxic opened this issue Aug 11, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@phloxic
Copy link
Contributor

phloxic commented Aug 11, 2015

"Adobe Flash is disabled for this page, click player area to enable" only makes sense if !flowplayer.support.flashVideo.
From a cursory glance at the code it probably must be more specific depending on the cirucumstances when flashdisabled is triggered.

@nnarhinen nnarhinen added this to the 6.0.4 milestone Aug 17, 2015
@nnarhinen
Copy link
Member

This is not true.

If you go tho chrome settings and choose in plugin options that you want to choose what plugins to run flowplayer.support.flashVideo is still true, even though the plugin is not loaded until the user decides to enable the plugin (by clicking the puzzle icon).

image

This is the whole purpose of flashdisabled event. To workaround the fact that the browser claims to have flash even though it won't run. And to run the plugins one has to click on the plugin, and we use flashdisabled event to bring the flash object up the visible DOM tree so that it can be directly clicked.

However, this should now behave better, as at least some of the timing issues for the timer that checks flashdisabled should be gone with ac5bf8e

@phloxic
Copy link
Contributor Author

phloxic commented Nov 12, 2015

Ah right, I forgot about the dialog thing.
I was coming from http://demos.flowplayer.org/api/live-check.html#javascript-setup where the 'disabled' message appears on error 4 or 9 when you try to load e.g. a dummy stream in spite of Flash unconditionally enabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants