Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashdisabled message does not make sense when Flash is in fact enabled #631

Closed
foliovision opened this issue Jun 27, 2022 · 0 comments
Closed

Comments

@foliovision
Copy link
Owner

Original issue link: #904 flashdisabled message does not make sense when Flash is in fact enabled


phloxic commented on Aug 11, 2015

"Adobe Flash is disabled for this page, click player area to enable" only makes sense if !flowplayer.support.flashVideo.
From a cursory glance at the code it probably must be more specific depending on the cirucumstances when flashdisabled is triggered.


nnarhinen commented on Nov 12, 2015

This is not true.

If you go tho chrome settings and choose in plugin options that you want to choose what plugins to run flowplayer.support.flashVideo is still true, even though the plugin is not loaded until the user decides to enable the plugin (by clicking the puzzle icon).

image

This is the whole purpose of flashdisabled event. To workaround the fact that the browser claims to have flash even though it won't run. And to run the plugins one has to click on the plugin, and we use flashdisabled event to bring the flash object up the visible DOM tree so that it can be directly clicked.

However, this should now behave better, as at least some of the timing issues for the timer that checks flashdisabled should be gone with ac5bf8e


phloxic commented on Nov 12, 2015

Ah right, I forgot about the dialog thing.
I was coming from http://demos.flowplayer.org/api/live-check.html#javascript-setup where the 'disabled' message appears on error 4 or 9 when you try to load e.g. a dummy stream in spite of Flash unconditionally enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant