Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.60.0 & Travis #102

Closed
johngeorgewright opened this issue Dec 1, 2017 · 6 comments
Closed

0.60.0 & Travis #102

johngeorgewright opened this issue Dec 1, 2017 · 6 comments

Comments

@johngeorgewright
Copy link

johngeorgewright commented Dec 1, 2017

I just tried updating to the new version of flow-bin. Any idea why my projects are producing the following errors on Travis?

Attempting to kill server for /home/travis/build/[user]/[project]
Unable to figure out pids of running Flow server. Try manually killing it with 'pkill flow' (be careful on shared devservers)
Failed to kill server for /home/travis/build/[user]/[project]

Versions:

$ node --version
v8.9.1
$ npm --version
5.5.1
$ nvm --version
0.33.6
{
  "dist": "trusty",
  "os": "linux"
}

0.59.x was working just fine, 0.60.0 also works fine on my mac.

@mroch
Copy link
Contributor

mroch commented Dec 1, 2017

"Attempting to kill server" happens when the /tmp/flow/<path to root>.lock file is locked but the .sockv2 file doesn't exist. the .sockv2 file is new in 0.60, so we expect to see this when there's a <=0.59 server running and holding the .lock file, and then you run a 0.60 client.

The "Unable to figure out pids of running Flow server" line is unexpected, though. That happens when the .pids file doesn't exist.

Are you perhaps caching /tmp/flow in travis (or setting --temp-dir or FLOW_TEMP_DIR)? shooting in the dark a bit.

eps1lon added a commit to eps1lon/poe-mods that referenced this issue Dec 1, 2017
attempt to fix #7 which is also caused in flow/flow-bin#102
@eps1lon
Copy link

eps1lon commented Dec 1, 2017

I let travis run rm -rf /tmp/flow right before npm run flow which didn't fix this.

@mroch
Copy link
Contributor

mroch commented Dec 1, 2017

alright I think I have a repro

@mroch
Copy link
Contributor

mroch commented Dec 1, 2017

removing /tmp/flow turns out to be the exact opposite of the solution :)

i'm pushing 0.60.1. a workaround is to mkdir /tmp/flow before calling flow the first time, but I would just stick with 0.59 for the next hour or so instead.

@mAAdhaTTah
Copy link

mAAdhaTTah commented Dec 1, 2017

Having the same problem. Opened #103 before seeing this one.

@johngeorgewright
Copy link
Author

johngeorgewright commented Dec 2, 2017

Thanks @mroch! 0.60.1 works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants