Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1.2 breaks the useLSP: false mode #341

Closed
vojtatranta opened this issue Jun 12, 2019 · 4 comments
Closed

1.1.2 breaks the useLSP: false mode #341

vojtatranta opened this issue Jun 12, 2019 · 4 comments

Comments

@vojtatranta
Copy link

  • it will not start server at all
  • it says that any command listed in the readme does not exist even though it is available in the commnad menu in VS code
@Mayank1791989
Copy link
Contributor

Yes the useLSP: false mode is broken (due to this 43d2462). I will push the fix for now you can use v1.1.1.

@Mayank1791989 Mayank1791989 changed the title 1.1.2 breaks with flow at least around 0.74.0 1.1.2 breaks the useLSP: false mode Jun 12, 2019
@balzdur
Copy link

balzdur commented Jun 12, 2019

FYI: still broken with v1.1.3

@vojtatranta
Copy link
Author

Yeah I noticed that 1.1.1 works so its OK. I just reported it, bwmecause I noticed.

@Mayank1791989
Copy link
Contributor

Will be fixed in v1.1.4

@Ligerx Ligerx mentioned this issue Jun 13, 2019
Closed
@Mayank1791989 Mayank1791989 mentioned this issue Jun 13, 2019
Closed
Mayank1791989 added a commit that referenced this issue Jun 22, 2019
@Mayank1791989
fix(build): close #341
869094b 
issue
- rollup doesn't correctly handle mix modules (import and require) files which
  results in inline require files not getting included in final build.
- log4js uses dynamic requires

fix
- replace all require with import in code
- remove log4js dependency. (use same Logger as used in flowLSP code)

other changes
- add eslint rules to prevent this happening in future.
@orta orta closed this as completed in c6bacf0 Jun 22, 2019
orta added a commit that referenced this issue Jun 22, 2019
@orta
Merge pull request #347 from Mayank1791989/fix/build
e018f38 
fix issue #341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mayank1791989 @vojtatranta @balzdur