Cannot rename variable when cursor is at the end of variable

[madacol]

Issue Type: Bug

1. Wait like 30 seconds after VSCode is opened
2. Position cursor at the right's edge of variable
3. Press F2 to rename variable
4. Change name
5. Press Enter
6. Variable is not modified

I disabled all extension except Flow and reloaded editor to pinpoint the extension causing it

Extension version: 1.1.4
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:55:08.091Z)
OS version: Linux x64 4.15.0-54-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz (6 x 3900)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: disabled_software skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: unavailable_off viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	2, 3, 2
Memory (System)	15.53GB (0.30GB free)
Process Argv	--unity-launch
Screen Reader	no
VM	57%

[Mayank1791989]

Try renaming test var on the code below

// @flow
function renameTest() {
	const test = "some_value";
	console.log(test);
}

Also share some simple case where it's not working for you.

[madacol]

Try renaming test var on the code below

It works fine in a fresh workspace

---

I just tested in a different environment with a fresh install of flow

Setup the workspace:

1. Open a new empty folder with vscode
2. Add an empty .flowconfig file
3. Add another file with your sample content

// @flow
function renameTest() {
	const test = "some_value";
	console.log(test);
}

4. Set language to Javascript
5. Wait till flow completes coverage check
   
6. Done!.

Now If you put the cursor at the end of a variable then press F2 and then try to rename it, it won't work.

[Mayank1791989]

Did you save the file before renaming? Flow rename read file content from disk. Is it working if cursor is on variable (say on e of test)?

[Mayank1791989]

@madacol Yes I can reproduce the issue now. It's happening when cursor is in the end. I will look into it. Thanks for reporting.