Flow start error on windows after update to 1.4.0

[petr-vacek]

After update to 1.4.0 starting flow end with error:

Failed to start flow Error: Not a valid file url 'filE:///e:/Blabla-Flex/blabla-ex'

The directory on local disk exists of course. The problem is likely the "filE" part as product of try to change the drive letter to uppercase... at fixed place

Workaround: go back to 1.3.0

[Mayank1791989]

When is this happening? Set flow.trace.server: "verbose" and share the output of flow panel. Also share vscode and flow version.

[petr-vacek]

vscode 1.38.0 (latest]
flow 0.97.0

Flow console output:
[Info - 9:00:07 - abra-cx.flowconfig] Found flow using option useNPMPackagedFlow
[Info - 9:00:08 - abra-cx.flowconfig] Using flow 'e:\ABRA-Flexi\abra-cx\node_modules\flow-bin\flow-win64-v0.97.0\flow.exe' (v0.97.0)
[Error - 9:00:08 - abra-cx.flowconfig] Failed to start flow
Error: Not a valid file url 'filE:///e:/ABRA-Flexi/abra-cx'

[Mayank1791989]

@petr-vacek Can you try with some latest flow. I can't reproduce the issue on my system.

[petr-vacek]

Upgraded flow to 0.107.0 -> same result.
Bellow I'm sending the flow trace server output ->

[Info  - 10:06:38 - abra-cx\.flowconfig] Found flow using option `useNPMPackagedFlow`
[Info  - 10:06:38 - abra-cx\.flowconfig] Using flow 'e:\ABRA-Flexi\abra-cx\node_modules\flow-bin\flow-win64-v0.107.0\flow.exe' (v0.107.0)
[Trace - 10:06:38] Sending request 'initialize - (0)'.
Params: {
    "processId": 18580,
    "rootPath": "e:\\ABRA-Flexi\\abra-cx",
    "rootUri": "filE:///e:/ABRA-Flexi/abra-cx",
    "capabilities": {
        "workspace": {
            "applyEdit": true,
            "workspaceEdit": {
                "documentChanges": true,
                "resourceOperations": [
                    "create",
                    "rename",
                    "delete"
                ],
                "failureHandling": "textOnlyTransactional"
            },
            "didChangeConfiguration": {
                "dynamicRegistration": true
            },
            "didChangeWatchedFiles": {
                "dynamicRegistration": true
            },
            "symbol": {
                "dynamicRegistration": true,
                "symbolKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25,
                        26
                    ]
                }
            },
            "executeCommand": {
                "dynamicRegistration": true
            },
            "configuration": true,
            "workspaceFolders": true
        },
        "textDocument": {
            "publishDiagnostics": {
                "relatedInformation": true
            },
            "synchronization": {
                "dynamicRegistration": true,
                "willSave": true,
                "willSaveWaitUntil": true,
                "didSave": true
            },
            "completion": {
                "dynamicRegistration": true,
                "contextSupport": true,
                "completionItem": {
                    "snippetSupport": true,
                    "commitCharactersSupport": true,
                    "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],
                    "deprecatedSupport": true,
                    "preselectSupport": true
                },
                "completionItemKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25
                    ]
                }
            },
            "hover": {
                "dynamicRegistration": true,
                "contentFormat": [
                    "markdown",
                    "plaintext"
                ]
            },
            "signatureHelp": {
                "dynamicRegistration": true,
                "signatureInformation": {
                    "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],
                    "parameterInformation": {
                        "labelOffsetSupport": true
                    }
                }
            },
            "definition": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "references": {
                "dynamicRegistration": true
            },
            "documentHighlight": {
                "dynamicRegistration": true
            },
            "documentSymbol": {
                "dynamicRegistration": true,
                "symbolKind": {
                    "valueSet": [
                        1,
                        2,
                        3,
                        4,
                        5,
                        6,
                        7,
                        8,
                        9,
                        10,
                        11,
                        12,
                        13,
                        14,
                        15,
                        16,
                        17,
                        18,
                        19,
                        20,
                        21,
                        22,
                        23,
                        24,
                        25,
                        26
                    ]
                },
                "hierarchicalDocumentSymbolSupport": true
            },
            "codeAction": {
                "dynamicRegistration": true,
                "codeActionLiteralSupport": {
                    "codeActionKind": {
                        "valueSet": [
                            "",
                            "quickfix",
                            "refactor",
                            "refactor.extract",
                            "refactor.inline",
                            "refactor.rewrite",
                            "source",
                            "source.organizeImports"
                        ]
                    }
                }
            },
            "codeLens": {
                "dynamicRegistration": true
            },
            "formatting": {
                "dynamicRegistration": true
            },
            "rangeFormatting": {
                "dynamicRegistration": true
            },
            "onTypeFormatting": {
                "dynamicRegistration": true
            },
            "rename": {
                "dynamicRegistration": true,
                "prepareSupport": true
            },
            "documentLink": {
                "dynamicRegistration": true
            },
            "typeDefinition": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "implementation": {
                "dynamicRegistration": true,
                "linkSupport": true
            },
            "colorProvider": {
                "dynamicRegistration": true
            },
            "foldingRange": {
                "dynamicRegistration": true,
                "rangeLimit": 5000,
                "lineFoldingOnly": true
            },
            "declaration": {
                "dynamicRegistration": true,
                "linkSupport": true
            }
        },
        "telemetry": {
            "connectionStatus": {
                "dynamicRegistration": false
            }
        },
        "window": {
            "status": {
                "dynamicRegistration": false
            }
        }
    },
    "initializationOptions": {
        "liveSyntaxErrors": true,
        "useCodeSnippetOnFunctionSuggest": true
    },
    "trace": "verbose",
    "workspaceFolders": [
        {
            "uri": "filE:///e:/ABRA-Flexi/abra-cx",
            "name": "abra-cx"
        }
    ]
}


[Trace - 10:06:38] Received response 'initialize - (0)' in 190ms. Request failed: Not a valid file url 'filE:///e:/ABRA-Flexi/abra-cx' (-32602).
Error data: {
    "stack": "Raised at file \"hack/utils/lsp/lsp_helpers.ml\", line 22, characters 6-90\nCalled from file \"src/lsp/flowLsp.ml\", line 1571, characters 17-57\nCalled from file \"src/lsp/flowLsp.ml\", line 1541, characters 12-58\n"
}


[Error - 10:06:38 - abra-cx\.flowconfig] Failed to start flow
Error: Not a valid file url 'filE:///e:/ABRA-Flexi/abra-cx'
[Trace - 10:06:38] Sending request 'shutdown - (1)'.
[Trace - 10:06:38] Received response 'shutdown - (1)' in 8ms.
No result returned.


[Trace - 10:06:38] Sending notification 'exit'.
No parameters provided.

[petr-vacek]

My suspicion: You try to convert the "e" drive letter to uppercase, but you do not count on the "file:///" prefix, so the "e" in the "file:" keyword is converted instead...

[petr-vacek]

I confirm that the version 1.5.0 works fine. Thanks.

[Mayank1791989]

Thanks @petr-vacek for reporting the issue.