Allow workspaceRoot variable in pathToFlow #173
Merged
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow.useNPMPackagedFlow
wasn't adequate for my use-cases (node_modules not at root, a copy for flow-bin outside of node-modules, etc).I was resorting to this hack:
"postinstall": "cp .vscode/settings.example.json .vscode/settings.json && sed -i '' \"s ROOT_REPLACE_ME $(pwd) \" .vscode/settings.json"
Ideally this would be solved by vscode; there is an open issue: microsoft/vscode#2809 however it seems harmless to add this.
I tested locally with:
"flow.pathToFlow": "${workspaceRoot}/my-flow"
)"flow.pathToFlow": "${workspaceRoot}/my-nonexistent-flow"
).config('pathToFlow').replace
does not throw)