Disable URL-encoding of paths in the language client to make LSP work on Windows #239
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
The diff's got a lot of double quotes changed to single quotes unnecessarily - some kind of linter auto-fix? |
The Flow LS doesn't know how to process url-encoded Windows file paths, making the extension not work on that OS unless it is disabled.
jbachhardie
force-pushed
the
windows-file-path-fix
branch
from
23ad1c1
to
f15fae4
Compare
|
ah, yes, rogue autoformatter. I've amended the commit, should be proper now. |
|
Cool, yep, looks good to me |
|
Thanks! I've shipped this as 0.8.1 |
The Flow LS doesn't know how to process url-encoded Windows file paths, making the extension not work on that OS unless it is disabled.
This fixes #238