Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #327 #335 #323 & some other changes #337

Merged
merged 8 commits into from
Jun 11, 2019

Conversation

Mayank1791989
Copy link
Contributor

@Mayank1791989 Mayank1791989 commented Jun 10, 2019

Changes | Features

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@orta
Copy link
Contributor

orta commented Jun 11, 2019

Yeah, this all looks good for me. 👍

The changing of the default for flow.useNPMPackagedFlow is a bit controversial, but I fall on the same side you do. So let's give that a go for a while and see how it works out. It's how I'd expect it to work by default.

@orta orta merged commit 2cf9465 into flow:master Jun 11, 2019
@orta
Copy link
Contributor

orta commented Jun 11, 2019

Alright, that is shipped

Publishing flowtype.flow-for-vscode@1.1.2...
 DONE  Published flowtype.flow-for-vscode@1.1.2
Your extension will live at https://marketplace.visualstudio.com/items?itemName=flowtype.flow-for-vscode (might take a few seconds for it to show up).

@Mayank1791989
Copy link
Contributor Author

Thanks @orta

@Mayank1791989 Mayank1791989 deleted the feat/updates branch June 11, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle might be bigger than expected (vscode recommends bundling it with Webpack)
3 participants