Check on edit #87
Merged
Check on edit #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `isWatching` got deprecated in favor of `isBackground`. - latest vscode does not recognizes version `0.3.2`.
- Adds status indicator inspired by one in vscode-jest, that is shown spinner when flow is type busy. - Adds `flow.showStatus` setting so that status indicator can be disabled if not desired.
|
This feels 👍 to me, as the commits form #85 are in here - I'll wait until that's merged for this to be good to go. |
|
Alright, with #85 in, this looks good too 👍 |
Gozala
added a commit
to Gozala/flow-for-vscode
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this pull unfortunately includes changes from #85, I'll rebase this once hopefully #85 lands. This change implements short term solution described in #26. To be clear if you have edits in multiple files that aren't saved, it will report errors for the active document as if it was saved but will ignore all other unsaved changes because: