Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

express Request.hostname is a string, not a boolean #666

Merged
merged 1 commit into from
Feb 25, 2017
Merged

express Request.hostname is a string, not a boolean #666

merged 1 commit into from
Feb 25, 2017

Conversation

idris
Copy link
Contributor

@idris idris commented Feb 20, 2017

No description provided.

@philikon
Copy link
Contributor

Bonus points if you could add a test.

@idris
Copy link
Contributor Author

idris commented Feb 24, 2017

@philikon I'm not sure what I would test here. A test would just make sure that hostname is a string, but that's just a copy of the line I changed, so the test really isn't providing anything other than duplicate code.

@marudor marudor merged commit 473c121 into flow-typed:master Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idris @philikon @marudor