Fix for args not using camel case in path #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@warmans there seem to be some lint errors |
|
oops, should be fixed now. |
|
still has some, run |
|
I don't think the CI integration is working properly. It's still complaining about stuff that is fixed (e.g. the substring callback arg no longer exists) 🤷♂️ |
|
I will look at it tomorrow :) |
vmasek
requested changes
Apr 6, 2018
src/parser.ts
Outdated
| @@ -48,8 +48,11 @@ function parseMethods({paths, security, parameters}: Swagger): Method[] { | |||
| ), | |||
| methodType: methodType.toUpperCase() as MethodType, | |||
| parameters: transformParameters(operation.parameters, parameters || {}), | |||
| // turn path interpolation `{this}` into string template `${args.this} | |||
| // tslint:disable-next-line:no-invalid-template-strings | |||
There was a problem hiding this comment.
this line can be removed, there is no more invalid template string warning
vmasek
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42
This resolves the issue with incorrect case used in paths. There is an example of the issue in the github api.