-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flox envs
command
#1264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysndr
commented
Apr 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ysndr
force-pushed
the
feat/command/envs
branch
2 times, most recently
from
April 17, 2024 16:30
d680066
to
c9087aa
Compare
ysndr
commented
Apr 17, 2024
ysndr
force-pushed
the
feat/command/envs
branch
from
April 17, 2024 16:45
c9087aa
to
b0e9ae6
Compare
ysndr
commented
Apr 17, 2024
zmitchell
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the other comments I've left, it would be nice to write a couple of tests for get_registered_environments
, etc.
ysndr
force-pushed
the
feat/command/envs
branch
from
April 23, 2024 15:51
b0e9ae6
to
4231c52
Compare
ysndr
force-pushed
the
feat/command/envs
branch
from
April 23, 2024 16:02
4231c52
to
b45a34d
Compare
zmitchell
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an environment registry and
flox envs
command.Flox commands has so far been mostly stateless, i.e. the fact that an environment exists at a given path is "forgotten" as soon as the command completes.
flox envs
is supposed to list both active and available/inactive environments (that are represented by .flox directories).To avoid scanning for
.flox
directories, we use the env registry introduced in #1312.In addition, the
flox envs
supports filtering the output to only active environments as well as formatting its output as JSON.