feat(PyProject::detect): detect unconventional requirements.txt (#1323)

[crsche]

Proposed Changes

Detect a wider set of Python requirements files using regex (^requirements\S*\.txt), since pip explicitly does not require naming the file requirements.txt.

Closes #1323

Release Notes

Change Python requirements file matching from requirements.txt to requirements*.txt

[mkenigs]

Thanks, overall looks good! I left a bunch of nonblocking comments and nits, so you can decide whether or not to address those.

The other thing is we could consider installing every requirements*.txt file like @zmitchell mentioned here #1323 (comment). Up to you if you want to make that change

[mkenigs]

Changes look good! Sorry I missed this before but describe_reason needs to be updated as well. Right now it's printing

Flox detected a Python project with the following Python provider(s):

* latest python (requirements.txt)

And describe_customization also hardcodes requirements.txt:

Installs the dependencies from the requirements.txt to the venv.

[mkenigs]

Also could you run cargo clippy and address any warnings? (there are a few warnings unrelated to your change that I fixed if you want to rebase against main so you don't get the noise)

[crsche]

Will do, sorry for the hassle, I'm a bit new to contribution.

[mkenigs]

Will do, sorry for the hassle, I'm a bit new to contribution.

No worries we need to add a CI job that runs clippy and add it to the contributor guidelines, that's on us!

[crsche]

Should we update the describe_reason method in the Provider trait to allow for a non-static Cow<str>? This would be necessary to list all the requirements files, something like:

Flox detected a Python project with the following Python provider(s):

* latest python (requirements.txt, requirements_dev.txt, ...)

Same idea with describe_customization.

[mkenigs]

Should we update the describe_reason method in the Provider trait to allow for a non-static Cow<str>? This would be necessary to list all the requirements files, something like:

Yeah I think that's necessary for the behavior we want

[mkenigs]

Thanks!