Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: catalog changes for manifest man page #1486

Merged
merged 4 commits into from
May 29, 2024
Merged

docs: catalog changes for manifest man page #1486

merged 4 commits into from
May 29, 2024

Conversation

mkenigs
Copy link
Contributor

@mkenigs mkenigs commented May 23, 2024

Update the doc-catalog copy of the manifest man page with catalog
changes:

  • name, optional, and abs-path will be dropped
  • semver was documented but not actually supported.
  • pkg-path will be required.
  • prefer-pre-releases will be renamed to allow-pre-releases

Also add a note about loosening constraints to solve install failures.

Update the doc-catalog copy of the manifest man page with catalog
changes:
- `name`, `optional`, and `abs-path` will be dropped
- `semver` was documented but not actually supported.
- `pkg-path` will be required.
- `prefer-pre-releases` will be renamed to `allow-pre-releases`

### `script` - DEPRECATED
This field was deprecated in favor of the `profile` section.
It will be removed in a later release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nb: migrated to profile.common, more specifically

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly. Yes you would copy and paste hook.script into profile.common, but we deprecated hook.script in favor of a feature that has additional...features.

Copy link
Contributor

@ghudgins ghudgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments. none of them critical

@mkenigs mkenigs requested a review from ghudgins May 24, 2024 19:28
@mkenigs mkenigs requested a review from zmitchell May 27, 2024 14:47
@mkenigs mkenigs added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@mkenigs mkenigs added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@mkenigs mkenigs added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@mkenigs mkenigs added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@mkenigs mkenigs added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 3321da9 May 29, 2024
15 checks passed
@mkenigs mkenigs deleted the resolve branch May 29, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants