Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't deploy both typescript and python functions #137

Closed
jcandrade opened this issue Jun 11, 2021 · 4 comments · Fixed by #141
Closed

Can't deploy both typescript and python functions #137

jcandrade opened this issue Jun 11, 2021 · 4 comments · Fixed by #141
Labels

Comments

@jcandrade
Copy link
Contributor

I'm trying to deploy 2 functions: one in typescript and one in python.
I didn't find anything on the documentation of how to disable/enable per function, so I wonder if there's a configuration for that. Also, I think python functions should be automatically ignored.

If there's no such feature, I can create a PR for either toggling the plugin per function or for ignoring functions with python set as the runtime.

@floydspace
Copy link
Owner

Hi @jcandrade, thank you for the issue and PR.
Of course, it does not make sense to use the plugin with python functions. I'd like to know how do you pack the python lambda eventually? normally it should be packed as it is, not just skipped. Maybe it's good idea to have an option toggling the plugin per function, but we don't have such. The plugin is intended to be used only with nodejs runtimes. I'm wondering how does the serverless-webpack plugin behave in this case 🤔 ?

@jcandrade
Copy link
Contributor Author

Hey @floydspace, thanks for the quick response.
Actually, after skipping the python lambda like I did on the PR, it simply packages the function as it is, which is what we expect.
To be honest, I didn’t check the serverless-webpack plugin because I already used your plugin in other ts projects and it fits perfectly ;)

@floydspace
Copy link
Owner

Thanks, @jcandrade , I will test your PR with an example, the code looks good to me. Appreciate for contribution 🙏

@jcandrade
Copy link
Contributor Author

Thank you! Let me know if I can help you on testing or on creating a sample code.

@olup olup linked a pull request Jun 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants