New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(packaging): exclude optional peer dependencies #113
Conversation
// this is needed for dependencies that maps to a path (like scoped ones) | ||
!depWhiteList.find(dep => doSharePath(localPath, 'node_modules/' + dep)) | ||
) | ||
const filesPathList = files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from there on it's just auto-formatting from my end. Is my formatting wrong or is it Calle Kabo's version that is not synced with the prettierrc ?
Added the exclusions of peer dependencies when listed in the |
@olup I've tested the latest update to this PR locally and it's back to square one.
|
@arpadgabor Yep, caught that, fixed now. This should be running now and the PR should be complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @olup
🎉 This PR is included in version 1.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This excludes optional dependencies to be installed when resolving peer dependencies.
It also replaces glob with globby in
pack.ts
, however, this does not change much anything as we still need tostat
for the file mode. Globby can stat for us in one pass, but the types are not yet complete on their side. I took the lazy route here and just replaced glob. We can improve that later on.