Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable esm format #342

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: enable esm format #342

merged 1 commit into from
Jul 20, 2022

Conversation

samchungy
Copy link
Collaborator

@samchungy samchungy commented Jul 19, 2022 •
edited

Recommend setting format to esm to enable ESM support. This PR enables us to recognise when we are in "ESM" mode or not.

Leaving the platform as node has its advantages.

eg.

All [built-in node modules](https://nodejs.org/docs/latest/api/) such as fs are automatically marked as [external](https://esbuild.github.io/api/#external) so they don't cause errors when the bundler tries to bundle them.

floydspace
floydspace approved these changes Jul 20, 2022
View reviewed changes
Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samchungy looks good, thanks

@samchungy samchungy merged commit fd3d4e6 into master Jul 20, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.32.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xczimi xczimi mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floydspace floydspace floydspace approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samchungy @floydspace