fix: preserve mtime when zipping #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
force-pushed
the
master
branch
6 times, most recently
from
a339b0e
to
273569d
Compare
This means it's possible for code to retrieve the correct mtime, for example to return in a `Last-Modified` header. Since we have a test which verifies a checksum of a zip file created by this function, we can be sure the results are deterministic. To support this, update the test inputs to have specified mtimes.
I want to run CI locally to test this change and it's not running because of the PR trigger. To be reverted before merging.
We're seeing
```console
npm ERR! notsup Not compatible with your version of node/npm: @aws-sdk/client-cloudformation@3.577.0
npm ERR! notsup Required: {"node":">=16.0.0"}
npm ERR! notsup Actual: {"npm":"8.19.4","node":"14.21.3"}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a wip to run CI
This means it's possible for code to retrieve the correct mtime, for example to return in a
Last-Modifiedheader.