Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for custom color palette and bold text as bright #83

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Add option for custom color palette and bold text as bright #83

merged 2 commits into from
Oct 3, 2022

Conversation

Acervans
Copy link
Contributor

@Acervans Acervans commented Oct 2, 2022

Added an array of strings in the config schema to input the color palette using hexadecimals or names:
It is the only way I could find to implement this in the current schema configuration file. Could be a temporary addition until the settings GUI is implemented .

Added a boolean to turn bold text's color to the bright counterparts.
An addition I personally think is useful for darker color palettes.

@Acervans Acervans mentioned this pull request Oct 2, 2022
Copy link
Owner

@flozz flozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! :D

I just have an interrogation about the default value of the palette (see below).


Coding style: please run black nautilus_terminal to fix the coding style automatically.

If you want to keep one channel per line here:

color_rgba = Gdk.RGBA(
    color[0] / 255.0,
    color[1] / 255.0,
    color[2] / 255.0,
    1
)

just add a comma after the last argument to avoid Black putting everything on one line:

color_rgba = Gdk.RGBA(
    color[0] / 255.0,
    color[1] / 255.0,
    color[2] / 255.0,
    1,
)

@flozz flozz merged commit 85917a4 into flozz:master Oct 3, 2022
@flozz
Copy link
Owner

flozz commented Oct 3, 2022

Thank you for this PR, I will try to release a new Nautilus Terminal version by the end of the week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants