Rival 106

[SethDusek]

Hi, what would it take to add rival 106 support? I have one so I could test any possible patches, and perhaps even try implementing a patch with a bit of guidance, however if I mess up the config like I did once before trying to shoehorn it into ratbag I would be in a bit of trouble since I'd have to reset it with someones windows machine.

[flozz]

Oops, I forget to answer this issue, sorry. :(

I started writing a doc about contributing if you want to help: https://github.com/flozz/rivalcfg/blob/rivalcfg4.0/doc/contributing.rst#unsupported-devices

[flozz]

I think the Rival 106 work the same than the Rival 110... Does someone have some time to make some tests with this mouse? :)

[SethDusek]

I have the mouse with me, how do I get started? Do I just copy rival110.py and change the product id?

[flozz]

Hello,

Clone this repository, checkout to the rivalcfg4.0 branch and simply add the Rival106 mouse to models list in the rival110.py file:

https://github.com/flozz/rivalcfg/blob/rivalcfg4.0/rivalcfg/devices/rival110.py#L13-L18

    "models": [{
        "name": "SteelSeries Rival 110",
        "vendor_id": 0x1038,
        "product_id": 0x1729,
        "endpoint": 0,
    }, {
        "name": "SteelSeries Rival 106",
        "vendor_id": 0x1038,
        "product_id": 0x1816,
        "endpoint": 0,
    }],

Then, just check each options to be sure it work. :)

NOTE: you may need to update udev rules to make it work (rivalcfg will give you the command if it is not up to date). :)

[SethDusek]

Yup, it works. Thanks! However I noticed that to get rivalcfg's 4.0 branch to work, I had to remove the argument from main, otherwise it would fail to launch with this error message:

Traceback (most recent call last):
File "/usr/bin/rivalcfg", line 11, in
load_entry_point('rivalcfg==4.0.0.dev0', 'console_scripts', 'rivalcfg')()
TypeError: main() missing 1 required positional argument: 'args'

This .patch includes both the changes to main and the product id added, if you're interested

[flozz]

Yup, it works. Thanks!

Yeah ! :D

Thanks! However I noticed that to get rivalcfg's 4.0 branch to work, I had to remove the argument from main, otherwise it would fail to launch with this error message:[...]

Oops you are right! I made a mistake here.

---

I will apply your patch for the Rival 106 part, but i prefer to keep an argument on the main() function, but with a default value (def main(args=sys.argv[1:]):). This argument is required for testing :)

[flozz]

Patch applied and issue fixed, thank you!