Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rgbgradient for the rival 700/710 #129

Merged
merged 5 commits into from
Aug 3, 2020
Merged

Add rgbgradient for the rival 700/710 #129

merged 5 commits into from
Aug 3, 2020

Conversation

nixtux
Copy link
Contributor

@nixtux nixtux commented Jul 30, 2020

No description provided.

flozz
flozz requested changes Jul 30, 2020
View reviewed changes
Copy link
Owner

@flozz flozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is globally OK excepting some documentation mistake and some questions. Do not hesitate to talk with me here or on Gitter if required ;)

rivalcfg/devices/rival700.py Outdated Show resolved Hide resolved
rivalcfg/devices/rival700.py Outdated Show resolved Hide resolved
rivalcfg/devices/rival700.py Outdated Show resolved Hide resolved
rivalcfg/devices/rival700.py Outdated Show resolved Hide resolved
rivalcfg/devices/rival700.py Outdated Show resolved Hide resolved
rivalcfg/handlers/rgbgradientv2.py Outdated Show resolved Hide resolved
rivalcfg/handlers/rgbgradientv2.py Show resolved Hide resolved
rivalcfg/handlers/rgbgradientv2.py Outdated Show resolved Hide resolved
rivalcfg/handlers/rgbgradientv2.py Outdated Show resolved Hide resolved
rivalcfg/helpers.py Outdated Show resolved Hide resolved
@nixtux nixtux mentioned this pull request Jul 30, 2020
Closed
@flozz flozz merged commit fc585f2 into flozz:rivalcfg4.0 Aug 3, 2020
@flozz
Copy link
Owner

flozz commented Aug 3, 2020

Merged, thank you! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flozz flozz flozz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nixtux @flozz