-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Prime mice #169
Conversation
Hum that's annoying, I have already an implementation for this in the aerox3-wireless branch... Maybe I can merge this part of the branch on Except this ↑ your PR looks great :) |
I had a look at the |
The updated |
The 'process_value' function of the 'range' handler is reused by 'multidpi_range'. Separate the actual processing in a different function. This will make it possible in future commits to change the return of 'process_value' for the 'range' handler.
Add support for outputting a value on multiple bytes. The new device option is called 'range_length_byte'.
OK I updated the code to use the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is just a key to rename to be more consistent with other devices. Great job! 👍
Thank you, the Prime support will be released in the next Rivalcfg version :) |
This adds support for the SteelSeries Prime mice (#166).
Supported features:
What is not supported:
By looking at the SSE3 database, it seems like the Prime and Prime+ support a new color handler. Instead, I was able to reuse the regular
color
handler by using thecommand
andcommand_suffix
fields to build a valid packet (but different from my captures). In short, the RGB color value is present twice in the data, at the start and at the end. Sending only at the start also works. But this means supporting the Prime+ will most likely require to correctly implement this new color handler.There were a few changes to the core code, mainly:
range
handler (new optionrange_length_byte
)multidpi_range
handler