Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized arguments error when no device is found. #213 #214

Conversation

LennardKittner
Copy link
Contributor

Solves #213 by checking if a supported device is found; if not, "E: No supported device found." is printed and the program exits.

I also fixed two typos in cli.py.

@LennardKittner
Copy link
Contributor Author

Strange on my device, all tests pass.

@LennardKittner
Copy link
Contributor Author

I fixed the tests by changing the occurrences of sys.argv in main to args.
This fixes the tests because sys.argv is empty in tests and args holds the real arguments.
However, this change also makes sense if we are not running tests because args is the actual function parameter and sys.argv is just the default value.

@flozz
Copy link
Owner

flozz commented Jun 25, 2023

Hello,

I will have no time to review this before ~ 1 or 2 weeks. I just want to let you know that I am not ignoring your PR :)

@LennardKittner
Copy link
Contributor Author

Alright, thank you for letting me know :)

@flozz flozz merged commit fc00642 into flozz:master Jul 4, 2023
5 checks passed
@flozz
Copy link
Owner

flozz commented Jul 4, 2023

Merged, thank you for the PR (and nice catch for the sys.argv... ^^').
It will be released with next rivalcfg version. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants