Pagerduty gateway - when polling for acks, get all acks at once

[jessereynolds]

Pagerduty's incidents api allows for retrieving all unresolved incidents in one go:

http://developer.pagerduty.com/documentation/rest/incidents/list

Eg:

https://acme.pagerduty.com/api/v1/incidents?fields=incident_number,status

In addition to adding a webhooks receiver for state changes from pagerduty (see #391), we should improve the polling interface to make just one request per contact/subdomain. We will likely need to support both polling and webhooks as some sites will prefer one over the other, or will want to employ both (for best of both worlds).

[auxesis]

👍

[chrisgagne]

This sounds like a wonderful improvement. On behalf of PagerDuty, I've just posted a $100 bounty on BountySource for the resolution of this issue: https://www.bountysource.com/issues/5333797-pagerduty-gateway-when-polling-for-acks-get-all-acks-at-once

[jessereynolds]

Thanks for your support @chrisgagne :-)

[chrisgagne]

Sure thing, @jessereynolds. Just doubled the bounty to $200. :)

[vegetableman]

Would like to give this a shot. Have a few questions.

options = ec_credentials.first.merge('check' => "#{entity_name}:#{check}")

The current code only handles the first contact of a failing entity, Shouldn't this need to be fixed as well?.

Also, when an entity receives an acknowledgement on pagerduty, it creates few entries on redis:

foo-app-01:HTTP:acknowledgement_notifications
foo-app-01:HTTP:actions

but the entity still remains unacknowledged on flapjack.
As Flapjack::Data::EntityCheck.unacknowledged_failing(:redis => @redis) returns all failing checks based on failed_checks , is this the desired behaviour?. So, pagerduty acks and flapjack acks are distinct?

[ghost]

I'm not sure what the bounty rules are regarding the release of the code -- this has been fixed in master, but v2 (which is what master is aiming towards) is still a little while away from a release.

[chrisgagne]

@ali-graham A flapjack maintainer has accepted the fix into master. That's good enough for me. :) I'll approve the claim from @kbailey4444. Thanks to you both!