Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to IUC style CI #90

Closed

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Aug 30, 2023

I just noted that there is no biocontainer for trimmomatic and thought that there should be. We could add this repo to planemo-monitor .. but for this, we should use state-of-the-art CI. Alternatively, we can move trimmomatic to IUC?

TODOs:

all tools that were previously tested
@pjbriggs
Copy link
Member

Hello @bernt-matthias thanks for the PR & sorry not to respond earlier - I've just got back after a couple of weeks.

Can I just check my understanding of the aims of the PR? If I understand correctly then:

  • The proposal is to add this repo (i.e. fls-bioinformatics-core/galaxy-tools) to planemo-monitor specifically in order to ensure testing of the trimmomatic tool. However as some (all?) of the other tools in the repository (which you not interested in?) are showing issues under planemo-monitor, a part of the proposal is to make certain modifications to the repo (outlined in the TODOs) so that planemo-monitor will skip testing of those tools.

  • An alternative to the proposal would be to transfer the trimmomatic tool to the IUC tool repository.

Does this sound correct? Thanks

@bernt-matthias
Copy link
Contributor Author

Jep

@bernt-matthias
Copy link
Contributor Author

An alternative to the proposal would be to transfer the trimmomatic tool to the IUC tool repository.

How about just doing this first?

@pjbriggs
Copy link
Member

Hello @bernt-matthias many apologies I have been meaning for some time to pick this up again but things have gotten away from me recently. Thanks for the reminder!

I did discuss this with my line manager and he was supportive of moving the Trimmomatic tool to the IUC repo, where I think it would be better cared for in future than I have been able to do over the past couple of years.

So if you think this is also a good idea then is it really just a case to begin with of making a PR on the https://github.com/galaxyproject/tools-iuc repo?

@bernt-matthias
Copy link
Contributor Author

is it really just a case to begin with of making a PR on the https://github.com/galaxyproject/tools-iuc repo?

Nearly. I could do this is desired.

The only thing needed from your side would to give write permission on the TS for the iuc account.

@pjbriggs
Copy link
Member

Thanks @bernt-matthias. I'm finishing now until the new year but I'm happy to start the PR when I get back. However if you'd like to begin before then that would also be okay with me.

@pjbriggs
Copy link
Member

pjbriggs commented Jan 3, 2024

@bernt-matthias happy new year! I've kicked off a new issue #91in this repo and started a branch in my fork of the IUC tools repo, but I haven't yet made a PR as there are a few things I'm unsure about - I'll add these to issue #91 next.

@pjbriggs pjbriggs mentioned this pull request Jan 8, 2024
5 tasks
@pjbriggs
Copy link
Member

Closing as PR has been superseded as Trimmomatic tool has now been relocated to the IUC tools repo (see issue #91 for details).

@pjbriggs pjbriggs closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants