bcftbx/IlluminaData: fix bug in IlluminaData class for mixed lane/no lane Fastqs #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lane Fastq names.
pjbriggs
force-pushed
the
IlluminData-handle-mixed-lane-no-lane-fqs
branch
from
ae4483f
to
f766f33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the
IlluminaDataclass (inbcftbx/IlluminaData.py) forbcl2fastq2-style outputs, when "mixed" Fastq names are found where some have lane numbers and others don't.This situation can occur if the
bcl2fastq-style output directory has actually been assembled from multiple runs of Fastq generation software where some projects have had e.g.--no-lane-splittingspecified and others haven't.In these cases the bug manifested itself as an error trying to sort the collected lane numbers (which had been acquired from the Fastq file names) (as the non-lane-split Fastqs return the lane as
None). The fix is to remove theNonelane designation from the list whenever such a mixture is encountered.