refactoring(<TaskForm>): rename shouldStartOnEditingMode to startOnEd…

…itingMode
flsilva · Nov 17, 2023 · f4902c7 · f4902c7
1 parent 386c4a9
commit f4902c7
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 9 deletions.
diff --git a/src/app/app/@dialog/(.)tasks/new/page.tsx b/src/app/app/@dialog/(.)tasks/new/page.tsx
@@ -13,7 +13,7 @@ export default function NewTaskDialogPage({ searchParams: { projectId } }: NewTa
     <Dialog defaultOpen routerActionOnClose={RouterActions.BackAndRefresh}>
       <TaskForm
         projectsSelect={<TaskProjectsSelect defaultValue={projectId} />}
-        shouldStartOnEditingMode
+        startOnEditingMode
         taskNameClassName="text-2xl"
       />
     </Dialog>

diff --git a/src/app/app/projects/[projectId]/page.tsx b/src/app/app/projects/[projectId]/page.tsx
@@ -24,7 +24,7 @@ export default function ProjectPage({ params: { projectId } }: ProjectPageProps)
           <TaskForm
             className="rounded-md bg-gray-100 px-2 py-6 sm:px-6 mt-4"
             projectsSelect={<TaskProjectsSelect defaultValue={projectId} />}
-            shouldStartOnEditingMode={true}
+            startOnEditingMode
           />
         </AddTask>
         <TaskList byProject={projectId} only={TaskStatus.Complete} />

diff --git a/src/app/app/tasks/[taskId]/page.tsx b/src/app/app/tasks/[taskId]/page.tsx
@@ -19,7 +19,6 @@ export default async function TaskPage({ params: { taskId } }: TaskPageProps) {
     <TaskForm
       className="mt-10"
       projectsSelect={<TaskProjectsSelect defaultValue={task.projectId} taskId={task.id} />}
-      shouldStartOnEditingMode={false}
       task={task}
       taskNameClassName="text-2xl"
     />

diff --git a/src/app/app/tasks/new/page.tsx b/src/app/app/tasks/new/page.tsx
@@ -12,7 +12,6 @@ export default function NewTaskPage({ searchParams: { projectId } }: NewTaskPage
       <h1 className="mb-6 text-xl text-gray-800">Create task</h1>
       <TaskForm
         projectsSelect={<TaskProjectsSelect defaultValue={projectId} />}
-        shouldStartOnEditingMode={false}
         taskNameClassName="text-2xl"
       />
     </div>

diff --git a/src/app/app/today/page.tsx b/src/app/app/today/page.tsx
@@ -41,7 +41,7 @@ export default function TodayPage() {
             className="rounded-md bg-gray-100 px-2 py-6 sm:px-6 mt-4"
             defaultDueDate={startOfDay(new Date())}
             projectsSelect={<TaskProjectsSelect />}
-            shouldStartOnEditingMode={true}
+            startOnEditingMode
           />
         </AddTask>
       </Suspense>

diff --git a/src/modules/app/tasks/TaskForm.tsx b/src/modules/app/tasks/TaskForm.tsx
@@ -24,7 +24,7 @@ export interface TaskFormProps extends ClassNamePropsOptional {
   readonly defaultDueDate?: Date | undefined;
   readonly onCancel?: () => void;
   readonly projectsSelect: React.ReactNode;
-  readonly shouldStartOnEditingMode?: boolean;
+  readonly startOnEditingMode?: boolean;
   readonly task?: TaskDto | null;
   readonly taskNameClassName?: string;
 }
@@ -34,7 +34,7 @@ export const TaskForm = ({
   defaultDueDate,
   onCancel,
   projectsSelect,
-  shouldStartOnEditingMode = false,
+  startOnEditingMode = false,
   task,
   taskNameClassName,
 }: TaskFormProps) => {
@@ -48,10 +48,10 @@ export const TaskForm = ({
     task && task.dueDate ? task.dueDate : defaultDueDate,
   );
   const [isCompleted, setIsCompleted] = useState(task && task.isCompleted);
-  const [isOnEditingMode, setIsOnEditingMode] = useState(shouldStartOnEditingMode);
+  const [isOnEditingMode, setIsOnEditingMode] = useState(startOnEditingMode);
 
   useEffect(() => {
-    if (shouldStartOnEditingMode) inputNameRef.current?.focus();
+    if (startOnEditingMode) inputNameRef.current?.focus();
   });
 
   const resetForm = () => {