Skip to content

Commit

Permalink
refactoring(<TaskForm>): rename shouldStartOnEditingMode to startOnEd…
Browse files Browse the repository at this point in the history
…itingMode
  • Loading branch information
flsilva committed Nov 17, 2023
1 parent 386c4a9 commit f4902c7
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/app/app/@dialog/(.)tasks/new/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default function NewTaskDialogPage({ searchParams: { projectId } }: NewTa
<Dialog defaultOpen routerActionOnClose={RouterActions.BackAndRefresh}>
<TaskForm
projectsSelect={<TaskProjectsSelect defaultValue={projectId} />}
shouldStartOnEditingMode
startOnEditingMode
taskNameClassName="text-2xl"
/>
</Dialog>
Expand Down
2 changes: 1 addition & 1 deletion src/app/app/projects/[projectId]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function ProjectPage({ params: { projectId } }: ProjectPageProps)
<TaskForm
className="rounded-md bg-gray-100 px-2 py-6 sm:px-6 mt-4"
projectsSelect={<TaskProjectsSelect defaultValue={projectId} />}
shouldStartOnEditingMode={true}
startOnEditingMode
/>
</AddTask>
<TaskList byProject={projectId} only={TaskStatus.Complete} />
Expand Down
1 change: 0 additions & 1 deletion src/app/app/tasks/[taskId]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export default async function TaskPage({ params: { taskId } }: TaskPageProps) {
<TaskForm
className="mt-10"
projectsSelect={<TaskProjectsSelect defaultValue={task.projectId} taskId={task.id} />}
shouldStartOnEditingMode={false}
task={task}
taskNameClassName="text-2xl"
/>
Expand Down
1 change: 0 additions & 1 deletion src/app/app/tasks/new/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export default function NewTaskPage({ searchParams: { projectId } }: NewTaskPage
<h1 className="mb-6 text-xl text-gray-800">Create task</h1>
<TaskForm
projectsSelect={<TaskProjectsSelect defaultValue={projectId} />}
shouldStartOnEditingMode={false}
taskNameClassName="text-2xl"
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/app/app/today/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default function TodayPage() {
className="rounded-md bg-gray-100 px-2 py-6 sm:px-6 mt-4"
defaultDueDate={startOfDay(new Date())}
projectsSelect={<TaskProjectsSelect />}
shouldStartOnEditingMode={true}
startOnEditingMode
/>
</AddTask>
</Suspense>
Expand Down
8 changes: 4 additions & 4 deletions src/modules/app/tasks/TaskForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface TaskFormProps extends ClassNamePropsOptional {
readonly defaultDueDate?: Date | undefined;
readonly onCancel?: () => void;
readonly projectsSelect: React.ReactNode;
readonly shouldStartOnEditingMode?: boolean;
readonly startOnEditingMode?: boolean;
readonly task?: TaskDto | null;
readonly taskNameClassName?: string;
}
Expand All @@ -34,7 +34,7 @@ export const TaskForm = ({
defaultDueDate,
onCancel,
projectsSelect,
shouldStartOnEditingMode = false,
startOnEditingMode = false,
task,
taskNameClassName,
}: TaskFormProps) => {
Expand All @@ -48,10 +48,10 @@ export const TaskForm = ({
task && task.dueDate ? task.dueDate : defaultDueDate,
);
const [isCompleted, setIsCompleted] = useState(task && task.isCompleted);
const [isOnEditingMode, setIsOnEditingMode] = useState(shouldStartOnEditingMode);
const [isOnEditingMode, setIsOnEditingMode] = useState(startOnEditingMode);

useEffect(() => {
if (shouldStartOnEditingMode) inputNameRef.current?.focus();
if (startOnEditingMode) inputNameRef.current?.focus();
});

const resetForm = () => {
Expand Down

0 comments on commit f4902c7

Please sign in to comment.