Skip to content

Commit

Permalink
Fl_File_Chooser now returns directory names with a trailing slash
Browse files Browse the repository at this point in the history
to avoid problems with relative filenames (STR #819)



git-svn-id: file:///fltk/svn/fltk/branches/branch-1.1@4335 ea41ed52-d2ee-0310-a9c1-e6b18d33e121
  • Loading branch information
michaelrsweet committed May 12, 2005
1 parent 3ce3d62 commit 56e8999
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 21 deletions.
3 changes: 3 additions & 0 deletions CHANGES
Expand Up @@ -2,6 +2,9 @@ CHANGES IN FLTK 1.1.7

- Documentation fixes (STR #648, STR #692, STR #730, STR
#744, STR #745)
- Fl_File_Chooser now returns directory names with a
trailing slash to avoid problems with relative
filenames (STR #819)
- Fl_Help_View now supports the FONT and U elements (STR
#815)
- OpenGL windows that were completely off-screen caused
Expand Down
23 changes: 2 additions & 21 deletions src/Fl_File_Chooser2.cxx
Expand Up @@ -1039,15 +1039,7 @@ Fl_File_Chooser::value(int f) // I - File number
if (!(type_ & MULTI)) {
// Return the filename in the filename field...
if (!name || !name[0]) return NULL;
else if (fl_filename_isdir(name)) {
if (type_ & DIRECTORY) {
// Strip trailing slash, if any...
strlcpy(pathname, name, sizeof(pathname));
slash = pathname + strlen(pathname) - 1;
if (*slash == '/') *slash = '\0';
return pathname;
} else return NULL;
} else return name;
else return name;
}

// Return a filename from the list...
Expand All @@ -1065,24 +1057,13 @@ Fl_File_Chooser::value(int f) // I - File number
strlcpy(pathname, name, sizeof(pathname));
}

// Strip trailing slash, if any...
slash = pathname + strlen(pathname) - 1;
if (*slash == '/') *slash = '\0';
return pathname;
}
}

// If nothing is selected, use the filename field...
if (!name || !name[0]) return NULL;
else if (fl_filename_isdir(name)) {
if (type_ & DIRECTORY) {
// Strip trailing slash, if any...
strlcpy(pathname, name, sizeof(pathname));
slash = pathname + strlen(pathname) - 1;
if (*slash == '/') *slash = '\0';
return pathname;
} else return NULL;
} else return name;
else return name;
}


Expand Down

0 comments on commit 56e8999

Please sign in to comment.