Compile error src/scandir_posix.c extra bracket

[markjolesen]

fl_scandir(const char *dir, struct dirent ***namelist,
int (*sel)(struct dirent *),
int (*compar)(struct dirent **, struct dirent **),
char *errmsg, int errmsg_sz) { // <--- ERROR BRACKET HERE
{ <-- AND HERE

produces compiler error

[Albrecht-S]

@erco77 @markjolesen Bug confirmed and fixed. Will commit shortly ...

[erco77]

@Albrecht-S be sure to test build; I think I see other problems; Line 485 in src/drivers/X11/Fl_X11_System_Driver.cxx calls fl_scandir() with only 4 arguments when HAVE_SCANDIR is unset, but ours expects 6..

[Albrecht-S]

@erco77 Thanks, Greg, I did only a quick hack to compile this source file and found that I also had to #include "flstring.h", see this patch: issue-162.diff.txt. I'm NOT going to commit this now because...

I can't do a full build with undefined HAVE_SCANDIR (too late, need some sleep). Please feel free to take over and go ahead, or drop me a note so I can continue tomorrow.

[Albrecht-S]

@markjolesen On which system / platform does this happen to you? Please be as precise as possible since this issue has long been unnoticed. Thanks for your help.

EDIT: please don't forget to tell us if you're building with autotools (configure/make) or CMake. TIA.

[erco77]

@Albrecht-S OK, I'll give it a shot. I'm basically unsetting HAVE_SCANDIR by hand-hacking the config.h.
Not sure what the OP's platform is.. would like to know what that is as well.

[Albrecht-S]

I'm basically unsetting HAVE_SCANDIR by hand-hacking the config.h.

👍

That's what I would have done too.

[markjolesen]

The Operating System I was using is FreeDOS 1.2 (I am getting fltkal project up to date with recent FLTK)

…

On Sun, Nov 22, 2020 at 7:11 PM Albrecht Schlosser ***@***.***> wrote: @erco77 <https://github.com/erco77> Thanks, Greg, I did only a quick hack to compile this source file and found that I also had to #include "flstring.h", see this patch: issue-162.diff.txt <https://github.com/fltk/fltk/files/5580748/issue-162.diff.txt>. I'm *NOT* going to commit this now because... I can't do a full build with undefined HAVE_SCANDIR (too late, need some sleep). Please feel free to take over and go ahead, or drop me a note so I can continue tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6DEU627KMBA3GIVV2SJ5LSRGZEZANCNFSM4T62RRFA> .

[erco77]

FreeDOS? Wow, well you might be in for an uphill battle, not sure.
We don't test for FreeDOS and I don't think we "officially" support it, but hey, if we can, we'll try.
Anyway, I'm close to a commit.. will follow up with something to try shortly..

[erco77]

OK, try a41d8c0.
It addresses another issue besides the brace issue you noticed, which may be relevant for you.

[markjolesen]

Over the years, I have just reported things that I think need fixing. Sometimes they do other times it's just noise. By the way, FLTK code is very portable.

…

On Sun, Nov 22, 2020 at 8:21 PM erco77 ***@***.***> wrote: OK, try a41d8c0 <a41d8c0> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6DEU4NVCS5TC3SMCRAI2TSRHBLDANCNFSM4T62RRFA> .

[Albrecht-S]

@erco77 I'm glad you took over. I think you know that errmsg stuff best.

I added the label "fixed" (again) and I believe we can close this issue. @erco77 , @markjolesen ?

[Albrecht-S]

No further comments since more than a month - closing this issue now.