Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake build installs files include/FL/Makefile.in and include/FL/README.Xcode #212

Closed
yurivict opened this issue Apr 10, 2021 · 2 comments
Closed

cmake build installs files include/FL/Makefile.in and include/FL/README.Xcode #212

yurivict opened this issue Apr 10, 2021 · 2 comments
Assignees
@Albrecht-S
Labels
bug Something isn't working CMake CMake bug or needs CMake support fixed The issue or PR was fixed.

Comments

@yurivict
Copy link

yurivict commented Apr 10, 2021 •
edited

These files don't look like they belong there.

Version 1.3.5
@Albrecht-S Albrecht-S self-assigned this Apr 10, 2021
@Albrecht-S Albrecht-S added bug Something isn't working CMake CMake bug or needs CMake support labels Apr 10, 2021
@Albrecht-S
Copy link
Member

Thanks for the report, I'll check this. ISTR that the entire FL/ folder gets installed which was probably correct in earlier versions. The additional files you mention should not be installed.

Please note also that FLTK 1.3.5 is pretty old now and FLTK 1.4 is the current development. FLTK 1.3.6 will be released soon but I'm not sure if a fix for this issue will make it into 1.3.6.

Albrecht-S pushed a commit that referenced this issue Apr 11, 2021
Fix CMake install procedure (#212)
3611d78 
Only install header files to the FL/ include directory.
Albrecht-S pushed a commit that referenced this issue Apr 11, 2021
Fix CMake install procedure (#212)
997ffe5 
Only install header files to the FL/ include directory.
@Albrecht-S
Copy link
Member

Fixed in master (1.4) and branch-1.3 (1.3.6).

@Albrecht-S Albrecht-S added the fixed The issue or PR was fixed. label Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Albrecht-S Albrecht-S

Labels
bug Something isn't working CMake CMake bug or needs CMake support fixed The issue or PR was fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurivict @Albrecht-S