Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic scaling broken in current revision? #239

Closed
wcout opened this issue Jun 18, 2021 · 4 comments
Closed

Dynamic scaling broken in current revision? #239

wcout opened this issue Jun 18, 2021 · 4 comments
Assignees
@Albrecht-S
Labels
bug Something isn't working fixed The issue or PR was fixed.

Comments

@wcout
Copy link
Contributor

wcout commented Jun 18, 2021

Scaling with keys CTRL+/- behaves very strange (Ubuntu 20.04):

  • shows 90% but size of window increases. - shows 110% but size decreases.
@Albrecht-S Albrecht-S self-assigned this Jun 18, 2021
@Albrecht-S Albrecht-S added the bug Something isn't working label Jun 18, 2021
@Albrecht-S
Copy link
Member

Yes, indeed. Thanks for the report. This is a regression introduced by the latest commit f94ed71. I'm looking into it...

Albrecht-S pushed a commit to Albrecht-S/fltk that referenced this issue Jun 18, 2021
Revert parts of and fix other 'constness' changes (fltk#239, fltk#181)
713d1bf 
Some of the previous constness changes turned out to be incomplete,
others had to be reverted because some other driver methods could
not be made 'const' - particularly those calling open_display() to
get the requested information.
@Albrecht-S Albrecht-S mentioned this issue Jun 18, 2021
Closed
@Albrecht-S
Copy link
Member

Albrecht-S commented Jun 18, 2021 •
edited

OK, this should be fixed now (713d1bf). Hopefully.

All feedback would be appreciated.

@bodomartin
Copy link

the latest commit fixes the issue for me. Many thanks for the almost instant reply & fix

@Albrecht-S
Copy link
Member

Thanks for the quick feedback as well.

My reaction was so quick because I was already working on it, and regressions are always taken seriously.

I'm closing this issue now again.

@Albrecht-S Albrecht-S added the fixed The issue or PR was fixed. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Albrecht-S Albrecht-S

Labels
bug Something isn't working fixed The issue or PR was fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wcout @bodomartin @Albrecht-S